Comments (4)
I guess this is intended to be used to construct the ideal set parent object for a given ring. But we should export such a function to the user from Oscar.jl rather than AbstractAlgebra.jl. That would then call the individual constructors in the various packages, rather than just import and export them. So I think I will remove the function in AbstractAlgebra.jl.
from abstractalgebra.jl.
from abstractalgebra.jl.
The problem isn't that they export the function IdealSet. They can do this just fine.
The problem is the intention of having a function in AA that can be overloaded by other packages. This doesn't work for things that could be constructing concrete types of the same name.
The intention of exporting it from AA is that other packages will import it. But Singular.jl would not do so, for example, because of the conflict with its own type of that name. So that kind of defeats the purpose of having it in the first place.
I would definitely expect that in the very long run, AA would itself define an IdealSet function which allows the definition of ideal sets for certain (very limited) ideals that it can construct. But the intention wouldn't be that other packages import this, since they probably do something much more sophisticated.
The principal of exporting dummy functions from AA that other packages can import and extend is actually fine. It just can't be done for things that might be types (with capital letters), unless the intention is that other packages NOT import them from AA.
from abstractalgebra.jl.
What I'm saying is that the other solution here is that I don't import IdealSet from AA in Singular.jl. But this demonstrates why it's a bad idea to define it with the intention of it being imported, because it just won't be in practice. It's fine to define it with the intention of it not being imported, as with many things with capital letters defined in AA.
from abstractalgebra.jl.
Related Issues (20)
- Implement `algebraic_closure(QQ)`
- Add a variant of `allow_unicode` which does not modify `LocalPreferences.toml` and only enables/disables unicode for the current session
- Invalidations caused by `lock(io::IOCustom)` HOT 2
- Documentation of aliases seems to fail on nightly? HOT 3
- Typo in incompatible rational function field error message
- Rename `UniversalPolynomialRing` to `universal_polynomial_ring`
- `@polynomial_ring` is broken for coefficient rings not in `AbstractAlgebra`. HOT 1
- `@polynomial_ring` support for key-value pairs is broken
- Add matrix conjugation method
- An example of bad behaviour of multivariate gcd HOT 4
- Methods for finding factors and roots of a polynomial in AbstractAlgebra.jl HOT 3
- Issues with `normalise` for polynomials.
- Make the GF function thread-safe HOT 4
- Use `WeakKeyIdDicts.jl` HOT 4
- Add conformance tests for `Generic.SparsePoly` HOT 1
- Add conformance tests for `Generic.FunctionField` / fix bugs this reveals HOT 1
- Move banner hiding code to a separate package? HOT 2
- cannot multiply elements in polynomial ring over a field of fractions HOT 1
- Invalid code in `ModuleIsomorphism`
- `view(::MatElem, ::Int, ::Int)` errors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstractalgebra.jl.