Giter Club home page Giter Club logo

Comments (5)

nekiro avatar nekiro commented on August 24, 2024

No idea, probably just wrongly registered ids in actions.xml or revscriptsys actions. It's default tfs code, so probably they used these items differently in older protocols (assuming you are running real map)

from tfs-1.5-downgrades.

dnvd avatar dnvd commented on August 24, 2024

Yes.
I'm comparing the files used in this repo:
https://github.com/peonso/tibialegacyserver/blob/master/server/data/actions/lib/actions.lua
https://github.com/peonso/tibialegacyserver/blob/master/server/data/actions/scripts/tools/pick.lua

with these used in this repo:
https://github.com/nekiro/TFS-1.4-Downgrades/blob/7.72/data/actions/lib/actions.lua
https://github.com/nekiro/TFS-1.4-Downgrades/blob/7.72/data/actions/scripts/tools/pick.lua

And there seems to be a big difference here if this is any help.

from tfs-1.5-downgrades.

nekiro avatar nekiro commented on August 24, 2024

As I said. I won't work on the datapack, so if you feel like making it better, submit a pull request, thanks.

from tfs-1.5-downgrades.

dnvd avatar dnvd commented on August 24, 2024

Ok, thank you for your response.
Maybe you want to keep the downgrade clean from these types of modifications?
I'm guessing that modifications in these files for the 7.72 branch could cause problems when merging from upstream later down the line?

I'm just trying to adjust to what works best for you. Otherwise I might send a PR later for this and for any future stuff as well.

from tfs-1.5-downgrades.

nekiro avatar nekiro commented on August 24, 2024

I don't think editing lua scripts, would be any kind of hassle when merging upstream, because what we do is cherry-pick relevant commits and just solve conflicts if any.

from tfs-1.5-downgrades.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.