Giter Club home page Giter Club logo

Comments (7)

NEGU93 avatar NEGU93 commented on May 30, 2024

Hello @osannolik, and thank you for the bug report.

This is an interesting insight. I was not expecting this to happen.
Here is how the bias is added. Indeed it seems like too much code for something so simple.
I also could optimize conv2D using gauss trick to do 3 convolutions instead of 4.

Due to the holidays, I won't sit with this right now. I might fix it in January, If you want, I invite you to also do a pull request if you need it ASAP.

from cvnn.

osannolik avatar osannolik commented on May 30, 2024

It would be nice to have it fixed as it is a pretty good optimization that would benefit more or less all users of ComplexConv2D. Not sure if I have the time to fix it myself in the near future unfortunately.

from cvnn.

Lunariz avatar Lunariz commented on May 30, 2024

Any updates on this? I recently started using ComplexConv2D and saw my training time slow down by a factor of 3~4.

I haven't tried enabling or disabling the bias specifically, but I can give that a try to see if that is the cause.

from cvnn.

NEGU93 avatar NEGU93 commented on May 30, 2024

Are you using batch norm? That is the main speed issue with my library.

from cvnn.

Lunariz avatar Lunariz commented on May 30, 2024

No, I'm not using any batch norm or layer norm at all!

from cvnn.

NEGU93 avatar NEGU93 commented on May 30, 2024

Unfortunately, I now work a full time engineer and no longer have time to keep developing/upgrading this library. I am sorry for those users but I don't think this feature is coming in the near future.

from cvnn.

NEGU93 avatar NEGU93 commented on May 30, 2024

I've been told that dividing by just the norm of the complex value would be good enough and it's quite fast to compute. I will leave it as an option in this issue.

from cvnn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.