Better syntax for custom enum names about magic_enum HOT 10 CLOSED

@Neargye, no, definitely not.

I'm just saying that if this is ever added to the API, it should be clear (in the documentation) that the macro should not be used inside class/namespaces.

from magic_enum.

@mhbackes you can check to customize branch https://github.com/Neargye/magic_enum/tree/customize.

I think to highlight everything in a separate namespace for customization. is this a normal name namespace magic_enum::customize?

from magic_enum.

@Neargye, sounds amazing.

I think the switch case is indeed the best option. This should work really well. Thanks!

from magic_enum.

One last question (very minor detail): does the function need to be auto?

template <>
constexpr std::string_view magic_enum::customize::enum_name<Color>(Color value) noexcept {
  switch (value) {
    case Color::RED:
      return "the red color"; // instead of `return std::string_view{"the red color"};`
    case Color::BLUE:
      return "The BLUE"; // instead of `return std::string_view{"The BLUE"};`
  }
  return ""; // instead of `return std::string_view{};`
}

I feel like declaring std::string_view as return gives a slight easier syntax.

from magic_enum.

update in master

from magic_enum.

@mhbackes

It might not be clear that you cannot declare it inside a class/namespace.

Is this functionality really necessary? First, it will clog the user class/namespace. Secondly, there may be some bad with ADL.

from magic_enum.

@mhbackes how about this https://github.com/Neargye/magic_enum/blob/e7309583de648bae5a4405a422c8912ce963a114/example/example_custom_name.cpp

from magic_enum.

template <>
constexpr auto magic_enum::customize::enum_name<Color>(Color value) noexcept {
  switch (value) {
    case Color::RED:
      return std::string_view{"the red color"};
    case Color::BLUE:
      return std::string_view{"The BLUE"};
  }
  return std::string_view{}; // "Empty string for default or unknow value."
}

or

MAGIC_ENUM_CUSTOM_NAME(Color::RED, "the REDcolor")
MAGIC_ENUM_CUSTOM_NAME(Color::BLUE, "the BLUEcolor")

from magic_enum.

// The reason for using a function is that a switch statement is, I believe, the
// only place where a compiler will check for exhaustiveness. If you forget to
// create a case for one of the enum's constants, the compiler can let you know.

Hm, maybe the switch option will be better.

from magic_enum.

Yes.
I think I'll correct the syntax before taking it to the master.

from magic_enum.