Giter Club home page Giter Club logo

Comments (4)

nazrulworld avatar nazrulworld commented on July 20, 2024

Related issue #58

I don't think we did some changes (from 6.0.0b5 to 6.1.0) related to Mypy/linting.

Are you using the same mypy version or upgraded?

from fhir.resources.

ItayGoren avatar ItayGoren commented on July 20, 2024

same one. the problem is that we didnt have typing before - it didnt find it and because i use --ignore-missing-imports i had no problems

from fhir.resources.

ItayGoren avatar ItayGoren commented on July 20, 2024

I continued to think about this problem and correct me if im wrong, but the ClassNameType is used because without it there is a circular imports flow. This circle occur because of Extensions which holds primitives and each primitive holds Extension. Is that the case?
If so, putting all of them in the same file would solve it. What do you think about it?
Another solution, is specifying the annotations in Extension using strings and not classes and do that only there.
What do you think? @nazrulworld

from fhir.resources.

nazrulworld avatar nazrulworld commented on July 20, 2024

you are right that primarly ClassNameType is used to solve FHIR's two-way relationship which introducing circular dependency. but this typing is also used as Pydantic field validator!

putting all of them in the same file would solve it. What do you think about it? I don't think that will solve the problem beside the problem, not just inside Extension, other places as well.
For example see relationship between Element <-> Extension class.

Another solution, is specifying the annotations in Extension using strings and not classes and do that only there.
That could be a good idea, let's try!

from fhir.resources.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.