Comments (4)
Related issue #58
I don't think we did some changes (from 6.0.0b5 to 6.1.0) related to Mypy/linting.
Are you using the same mypy version or upgraded?
from fhir.resources.
same one. the problem is that we didnt have typing before - it didnt find it and because i use --ignore-missing-imports
i had no problems
from fhir.resources.
I continued to think about this problem and correct me if im wrong, but the ClassNameType
is used because without it there is a circular imports flow. This circle occur because of Extensions
which holds primitives and each primitive holds Extension
. Is that the case?
If so, putting all of them in the same file would solve it. What do you think about it?
Another solution, is specifying the annotations in Extension
using strings and not classes and do that only there.
What do you think? @nazrulworld
from fhir.resources.
you are right that primarly ClassNameType
is used to solve FHIR's two-way relationship which introducing circular dependency. but this typing is also used as Pydantic field validator!
putting all of them in the same file would solve it. What do you think about it?
I don't think that will solve the problem beside the problem, not just inside Extension, other places as well.
For example see relationship between Element <-> Extension class.
Another solution, is specifying the annotations in Extension using strings and not classes and do that only there.
That could be a good idea, let's try!
from fhir.resources.
Related Issues (20)
- Validation error with ImagingStudy resource HOT 2
- Install to a Poetry environment HOT 2
- Incorrect parsing of StructureDefinition element ids for polymorphic elements HOT 2
- BundleEntryRequest validation error HOT 2
- Transition to R5 HOT 2
- `pkg_resources.declare_namespace` deprecation HOT 1
- urn not supported in Url
- FHIR resource as pydantic request model in FastAPI
- Pydantic 2.0 Migration Plan HOT 17
- Restrict Pydantic to <2.0.0 HOT 3
- Sample code execution error HOT 3
- Use warnings.warn() instead of logging the warning about the ignored extra parameters passed to json() and dict()
- Improve documentation of orjson HOT 1
- Parsing XML byte string MESH acknowledgment response HOT 2
- Instant on DocumentReference not properly output on json HOT 1
- Resource / element to be json-serializable HOT 2
- How to override validation HOT 2
- Handling FHIR Versions
- Error in ID length on EPIC Sandbox data HOT 4
- A way to get list of all resources and their inner elements, help needed in getting sub elements of inner elements HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fhir.resources.