Giter Club home page Giter Club logo

Comments (2)

nazrulworld avatar nazrulworld commented on August 20, 2024 2

@simonvadee thank you so much for raising this issue and sorry for any inconvenience.

note: Enum values can be used in validation, but use in your own responsibilities, read official FHIR documentation.
Means this validation is not part of built-in model validation, in other words not implemented (but possible to make custom validation depends on project needs (I will give example for this))

Why not ENUM validation included:

  1. first of all FHIR specification doesnโ€™t enforce this kind of validation, on the other hand enums are generated by parsing string, so all enums are not trusted. You will find that some enum list contains value '+', which means more value could be acceptable.
  2. I think it is possible to give other value, rather than only from the enum list by adding a new extension.
  3. If we add this enum validation as core part that could be a disaster for any project.

But we have that flexibility kept to make custom validation, moreover, it will be possible extend enum values!

Example:

from typing import Dict
from fhir.resources.patient import Patient

def validate_gender(cls, values: Dict):
    if not values:
        return values
    enums = cls.__fields__["gender"].field_info.extra["enum_values"]
    if "gender" in values and values["gender"] not in enums:
        raise ValueError("write your message")
    return values

Patient.add_root_validator(validate_gender, pre=True)

Here you will find, about better way to add custom validator #17 (comment)

from fhir.resources.

simonvadee avatar simonvadee commented on August 20, 2024

Thank you for the example, now I understand why (and how) enum validation is not enforced by default!

from fhir.resources.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.