/api/dcim/interfaces/ and /api/dcim/{console-ports,console-server-ports} behave differently when fetching elements for non-existent device about nautobot HOT 5 OPEN

The technical reason for this discrepancy appears to be because InterfaceFilterSet.device filter is a custom method filter (to account for interfaces on devices that are part of a virtual-chassis), which is explicitly returning queryset.none() in the case of DeviceDoesNotExist exception. Fixing this is probably as simple as changing that exception handling logic to raise an appropriate 400 error.

from nautobot.

Would an HTTP 404 be a better response code for this class of conditions?

from nautobot.

related: #5867

from nautobot.

My preference to remain REST compliant is that we return 0 results. This is technically a change in behavior so we will defer this to 3.0.

from nautobot.

I've not even attempted an exhaustive test to see which API calls return a 400, but as a data point, I did just trip over the fact that /relationship-associations/ returns a 400 if the passed relationship argument which doesn't exist:

{
  "relationship": [
    "Select a valid choice. foo is not one of the available choices."
  ]
}

...but returns a 200/OK with count=0 if you pass an id parameter which doesn't exist. As this seemed so closely related, I added it to this issue but LMK if you'd prefer I open a new issue on this.

from nautobot.