Applying filter in LocationTypeList View triggers key error about nautobot HOT 4 OPEN

Behavior confirmed in demo.nautobot.com as well.

from nautobot.

Let's use this bug fix as an opportunity to revisit how that block of code in utils/filtering.py works - this isn't the first time we've had an error like this.

from nautobot.

Maybe we could add a test to the generic list view testing to specifically test filtered list view, if we don't already have something appropriate? Either way would like to understand why our unittests don't catch this.

from nautobot.

Generic view tests don't catch this because the only filter they test by default is the id filter, and the dynamic filter form only calls get_filterset_parameter_form_field() for filters that are actively being applied. Maybe we could add a generic test that tries to apply all filters (or at least all of the ones that are easy to reverse-engineer values for from the model?) and confirms that the page renders successfully?

Might be appropriate to add additional test cases to nautobot.core.tests.test_forms.DynamicFilterFormTest as well.

from nautobot.