Giter Club home page Giter Club logo

Comments (9)

charliestrawn avatar charliestrawn commented on May 23, 2024 1

Yep no rush, totally a cosmetic update.

from nats.py.

charliestrawn avatar charliestrawn commented on May 23, 2024

I'd like to tackle this @wallyqs just wanted to call it out in issues as to get your thoughts and to not duplicate effort.

from nats.py.

wallyqs avatar wallyqs commented on May 23, 2024

@charliestrawn this sounds good to me! I was thinking of cutting a release for 0.9.0 today, would you like me to wait or can we include this in v0.9.1 maybe?

from nats.py.

wallyqs avatar wallyqs commented on May 23, 2024

Actually had already uploaded asyncio-nats-client 0.9.0 so we can add this to the next release. Thanks Charlie.

from nats.py.

Bernolt avatar Bernolt commented on May 23, 2024

Hello, if you still want to do this change. I could get a jump on it.

from nats.py.

wallyqs avatar wallyqs commented on May 23, 2024

@Bernolt that would be great, thanks!

from nats.py.

Bernolt avatar Bernolt commented on May 23, 2024

Actually, I ran a pyupgrade to get rid of them, it additinally got rid of:

  • old-style class definition
class C(object): pass     # class C: pass
class C(B, object): pass  # class C(B): pass
  • super calls
class C(Base):
    def f(self):
        super(C, self).f()   # super().f()

and of course switched f-strings instead of .format.

Do you mind if I keep those changes or you would prefer to stick to the f-string change only?

Also, f-string change will break compatibily with version of python below 3.6. Are you ok with that?

from nats.py.

wallyqs avatar wallyqs commented on May 23, 2024

Thanks for the PR, I think it is fine to allow for 3.6 as the minimum version.

from nats.py.

charliestrawn avatar charliestrawn commented on May 23, 2024

Yeah I'm pretty sure we are already using some things that bind us to 3.6 or later. Closing as addressed in #152

from nats.py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.