Giter Club home page Giter Club logo

Comments (12)

mickeyordog avatar mickeyordog commented on July 19, 2024

image
More info: here's what I see in the editor when this happens

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on July 19, 2024

I've seen one or two people run into something similar but we've yet to nail down what the cause is.

What version of the dotnet SDK do you have on your Mac and which one on Windows?

And if you change line 411 to...

line.set("responses", await get_responses(data.get("responses", []), resource, id_trail, extra_game_states))

...does it make a difference?

from godot_dialogue_manager.

GovermanGambo avatar GovermanGambo commented on July 19, 2024

I was also having this issue, but was able to fix it using get and set methods as you suggest above. Seems to be some strange race condition with the parsing of the scripts

from godot_dialogue_manager.

mickeyordog avatar mickeyordog commented on July 19, 2024

image
Here is the version for my Windows dotnet.
Thanks for the help, I made that change and ran the game about 20 times and didn't see the error again. I'll keep checking for the next few days and if I don't see the error again I'll come back to let you know and close the issue.

from godot_dialogue_manager.

mickeyordog avatar mickeyordog commented on July 19, 2024

Update: Nope, I'm still getting the error. My version on mac is 7.0.403

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on July 19, 2024

Is it the same line number and same error?

from godot_dialogue_manager.

mickeyordog avatar mickeyordog commented on July 19, 2024

I believe so, but when I get the error again I can report back

from godot_dialogue_manager.

mickeyordog avatar mickeyordog commented on July 19, 2024

image
Yep got it again. I believe this is the same line?
Side note: it seems to happen much more often when I just opened Godot. Could possibly be more likely when I run the project and it has to build .net vs when I build it using the build button then run? But really not sure

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on July 19, 2024

That's a line further down and doesn't have the same get/set stuff applied. I've implemented the fix for both occurrences as part this PR if you wanted to give it a try.

from godot_dialogue_manager.

mickeyordog avatar mickeyordog commented on July 19, 2024

Oh my mistake, you're right. Thanks for the fix!

from godot_dialogue_manager.

mickeyordog avatar mickeyordog commented on July 19, 2024

Hey @nathanhoad , I pulled your fixed but just got an error on a different line unfortunately
image

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on July 19, 2024

Looks like it could use another get("responses").

from godot_dialogue_manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.