Giter Club home page Giter Club logo

Comments (5)

NathanaelA avatar NathanaelA commented on June 10, 2024 1

I've just removed all the "function/property" hiding code, let me know if you have any other issues in 2.03. Technically the defineproperty code should work in a class constructor, but must have some weird issue with _notify being also in the superclass. In all reality as I was already debating stripping that code in the ES6 rewrite since it is mainly pointless.

from nativescript-websockets.

lapaliv avatar lapaliv commented on June 10, 2024

And while doing so, I successfully connected to the server, but could not continue to work with it

from nativescript-websockets.

NathanaelA avatar NathanaelA commented on June 10, 2024

This should be fixed in v2.02.

from nativescript-websockets.

Archez avatar Archez commented on June 10, 2024

This error still occurs with v2.0.2 when using the browser based method.

In the BrowserWebSockets class, if you comment out the line, then it works as expected (unless doing this breaks something else).

Object.defineProperty(this, "_notify", {enumerable: false});

This seems to make the NativeWebSockets class it extends not have reference to the function.


If the intent is to not have the property enumerable, then to correctly modify the property I believe we would want this instead

Object.defineProperty(this, "_notify", {enumerable: false, value: this._notify});

from nativescript-websockets.

NathanaelA avatar NathanaelA commented on June 10, 2024

That is interesting. I'll do an update.

from nativescript-websockets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.