Comments (3)
jphickey
commented on July 18, 2024
Related changes here:
- The code should NOT include
cfe_tbl_internal.hany more -- this is by definition an internal file, the tool does not and should not need to use any internal definitions from CFE_TBL. - The references to
CFE_TBL_MAX_FULL_NAME_LENcan be removed. Usesizeof(TableHeader.TableName)instead, and the alignment logic can be removed because the user should have definedCFE_MISSION_TBL_MAX_FULL_NAME_LENas a multiple of 4 anyway.
from elf2cfetbl.
jphickey
commented on July 18, 2024
On second look, both cases of ByteAlignFileHeaders and the associated command line option should probably be removed. It has no purpose if we are enforcing that these values are a multiple of 4 already via compile time asserts.
from elf2cfetbl.
skliper
commented on July 18, 2024
@jphicky are you done with this one? If so could you submit a pull request with the associated testing details? It all looks good to me.
from elf2cfetbl.
Related Issues (20)
- Remove explicit file name references in doxygen file comments to avoid warnings
- RST-IVV-179: ICDH Build 2: cFS Tool Contains Potentially Null Pointers that are De-referenced in Function HOT 2
- RST-IVV-177: ICDH Build 2: cFS Tool “elf2cfetbl” Experiences a Buffer Overflow when the Section Header Description Exceeds 60 Characters HOT 2
- Apply latest copyright header
- CodeQL Workflow Broken due to Name Change
- Uninitialized variable static analysis warning
- CMake script refers to obsolete path
- Poorly documented file
- Remove C++-style comments
- Variables declared mid-function
- ProcessCmdLineOptions - cyclomatic complexity of 45
- GetElfHeader - cyclomatic complexity of 36
- GetSectionHeader - cyclomatic complexity of 35
- LocateAndReadUserObject - cyclomatic complexity of 29
- main - cyclomatic complexity of 21
- References to time members in CFE_FS_Header_t should be converted to CFE_TIME_SysTime_t
- Inconsistent prototype in elf2cfetbl.c : OutputDataToTargetFile HOT 1
- Update Versioning System
- Does not build without feature test macro set externally
- Add CMake and other helper scripts needed to build CFE tables
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elf2cfetbl.