Bug with -g parameter on FreeBSD about check_smart HOT 3 CLOSED

Proposition: Change the regex in the source code that the user should decide which regular expression to use:

Source Code:

# glob all devices - try '?' first
@dev =glob($opt_g);

Run plugin on FreeBSD:

/usr/local/libexec/nagios/check_smart.pl -g "/dev/da[0-9]" -i scsi
OK: [/dev/da0] - Device is clean --- [/dev/da1] - Device is clean --- [/dev/da2] - Device is clean --- [/dev/da3] - Device is clean --- [/dev/da4] - Device is clean --- [/dev/da5] - Device is clean --- [/dev/da6] - Device is clean --- [/dev/da7] - Device is clean|

Run plugin on Linux:

/usr/lib/nagios/plugins/check_smart -g "/dev/sd[a-z]" -i ata
OK: [/dev/sda] - Device is clean --- [/dev/sdb] - Device is clean|

This way the plugin is open for several OS and hard drive names and there is no fixed regex in the source code.

Other solutions welcome!

from check_smart.

This would probably also resolve issue #7 as the regular expression given by the end user can also contain exclusions if the regex is well done.

from check_smart.

As there was no comment/feedback/complaint/argument about this change, I went on and committed 80a87ac .

from check_smart.