Cannot read properties of undefined (reading 'list') about homebridge-weather-plus HOT 6 CLOSED

Fixed and landed in #276

from homebridge-weather-plus.

Looking at the code, without reproducing it myself, this does definitely look like a bug.

In the update(forecastDays, callback) function in openweathermap.js, it tries to fetch the current forecast with the 2.5 API:

// Old api requires an extra call to get the forecast
if (this.api === "2.5")
{
	this.getWeatherData(this.apiBaseURL + "/data/2.5/forecast", (error, result) =>
	{
		this.generateForecasts(weather, result["list"], result["city"]["timezone"], callback);
	});
}

In the function getWeatherData(), if there is a requestError it calls the callback with a null result object, aka callback(requestError);

Then when it tries to process the response:
this.generateForecasts(weather, result["list"], result["city"]["timezone"], callback);
it does not take into account that an error may have occurred and the result object is null.

from homebridge-weather-plus.

I have a fix that would handle this error gracefully, aka log it and move on.
Can I send you an updated openweathermap.js file to test?

from homebridge-weather-plus.

Hello,
I have the same issue that occasionally occurs on version 3.2.11.
I would appreciate the update of the openweathermap.js file to test !
Thank you!

from homebridge-weather-plus.

Are we able to close this now?

from homebridge-weather-plus.

Hello thanks so much for the work! I missed the notifications unfortunately. Yes, we can close this now, thanks again!

from homebridge-weather-plus.