Comments (5)
mhamrah
commented on August 18, 2024
1
No immediate plans, but happy to accept PR's.
from docker-protoc.
noltedennis
commented on August 18, 2024
Hi @mhamrah and @rezam90,
I encountered the same issue yesterday and decided to try and extend the project with DART support. Attached you can find a patch file. Since this is my first open source contribution I am hesistant to open a PR directly and would like to collect thoughts and feedback first.
For DART support, I had to undertake the following changes:
- Change from Alpine-based image to Debian-Stretch based base-docker image, because the DART SDK afaik cannot be compiled with musl
- Add the DART SDK and plugin to the image. For quickness I did not build these myself and instead used the available Debian packages.
- With the change of the base image I had to swap out some dependenices
- For DART we need to include the Google pre-defined stubs, because the DART protobuf package - unlike most other packages - does not include these.
Since we changed the base image and added the Dart SDK, the Docker image size trippled. Would you still be willing to go forward with this change?
Kind regards,
Dennis
add-dart-support.patch.txt
from docker-protoc.
mhamrah
commented on August 18, 2024
I'm no longer a maintainer on the project, but I'm sure someone will work
with you.
…On Sat, May 2, 2020, 4:59 AM noltedennis ***@***.***> wrote:
Hi @mhamrah <https://github.com/mhamrah> and @rezam90
<https://github.com/rezam90>,
I encountered the same issue yesterday and decided to try and extend the
project with DART support. Attached you can find a patch file. Since this
is my first open source contribution I am hesistant to open a PR directly
and would like to collect thoughts and feedback first.
For DART support, I had to undertake the following changes:
1. Change from Alpine-based image to Debian-Stretch based base-docker
image, because the DART SDK afaik cannot be compiled with musl-ssl
2. Add the DART SDK and plugin to the image. For quickness I did not
build these myself and instead used the available Debian packages.
3, With the change of the base image I had to swap out some
dependenices
3. For DART we need to include the Google pre-defined stubs, because
the DART protobuf packages - unlike most other packages - does not include
these.
Since we changed the base image and added the Dart SDK, the Docker image
size trippled. Would you still be willing to go forward with this change?
Kind regards,
Dennis
add-dart-support.patch.txt
<https://github.com/namely/docker-protoc/files/4567344/add-dart-support.patch.txt>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWIGQEVSV5DDIQYRLZW6DRPPOFVANCNFSM4G73ZNXA>
.
from docker-protoc.
ido-namely
commented on August 18, 2024
Hi @noltedennis ,
Sorry for the late reply.
I don't know if you've lost interest in contributing, but I'm happy to review a PR if you submit it.
Since we switched to a debian based image since your last message, I don't think there should be any problems with the approach you've described.
from docker-protoc.
jcburley
commented on August 18, 2024
@r6m @noltedennis – please consider submitting a PR for this if you're still interested; else feel free to close it out. Thanks!
from docker-protoc.
Related Issues (20)
- Unable to build locally HOT 5
- Python GRPC out HOT 2
- Update grpc-web to 1.3.0 HOT 1
- [Question] imported files not compiled HOT 4
- Add Renovate Bot to automatically update variables.sh HOT 6
- Gitpod does not build docker-protoc
- how to log 504 gateway timeout at grpc-gateway? HOT 1
- Question: Is it possible to see what protoc version is used?
- prototool is not installed properly
- PHP files generator don't detect reserved class name Object HOT 2
- Feature Request: support stephenh/ts-proto as an alternative to improbable-eng/ts-protoc-gen HOT 3
- Dependency Dashboard
- protoc java: --with-validator option not working HOT 3
- ARM builds of docker image HOT 6
- ts_option is not reliable, while using useOptionals=none HOT 1
- Node version outdated HOT 1
- undefined: service.RegisterServiceHandlerFromEndpoint HOT 7
- feat: add new FieldBehavior value IDENTIFIER
- ts-proto version upgrade
- protoc version upgrade
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-protoc.