timer about nameko HOT 10 CLOSED

I'm afraid i don't understand you..
You want to wait on finish of last round and then new one will start, don't you?

from nameko.

the problem is that in the current implementation, we measure how long self.handle_timer_tick(). but that function calls spawn_worker which is asynchronous, and returns as soon as the handler is spawned, and doesn't wait for it to finish.

in the example above, you see 'tick' every second, even though the handler takes 5 seconds to run

from nameko.

I'm in favour of fixing this. I think the semantics should be either:

• At most once per interval seconds or
• Exactly interval seconds after the previous execution finishes

Looks like @Sparkycz's PR does the second option.

from nameko.

to me it looks like the pr waits interval - elapsed_time, which is what the original code tried to do, and my preferred choice i think. is this your option 1?

from nameko.

the both PRs are wrong.. i'm sending the first one now and then i will try to solve the second one. I'm sorry I havn't had a free time for it..

from nameko.

Currently it probably does what we want. If the service method works longer than interval Timer waits for the completion and then fires the next one.

from nameko.

@davidszotten Yep, waiting interval - elapsed_time is Option 1 and also my preference.

@Sparkycz I will add a few comments to the PR. Please address them and then we'll merge this down. Thanks!

from nameko.

Is this still being worked on? If it's just a matter of finishing up the tests I can give it a try

from nameko.

@daviskirk I think almost certainly not. A fix would be great!

from nameko.

@mattbennett see #579

from nameko.