abstracting out serializer about nameko HOT 5 CLOSED

Thanks! Glad you like it :)

Abstracting the serialization is certainly something we'd like to do. Kombu supports pluggable serializers (see http://kombu.readthedocs.org/en/latest/userguide/serialization.html) but we lazily hardcoded to JSON for the serialization checks in the RPC implementation.

Removing the hardcoding should be straightforward and let you fall back to using kombu's serialization, which is a step in the right direction.

from nameko.

Agree, that definitely is a step in the right direction - though kombu's API for registering custom serializers is not pretty - it requires a module installed with a registered entry point, but at least it's doable.

There still would need to be a configuration setting in nameko' - since serializers are registered at a consumer level, which nameko abstracts over.

from nameko.

You can also register them programmatically - http://kombu.readthedocs.org/en/latest/reference/kombu.serialization.html#kombu.serialization.register

Quite right about the config setting.

from nameko.

#244

from nameko.

Done and landed! (finally) Thanks @ayoshi

from nameko.