Giter Club home page Giter Club logo

Comments (5)

etataurov avatar etataurov commented on July 23, 2024

Yes, this will be great,
but...
for python 2 we need a lot of code, because we need to aquire import lock, call find_module for each submodule in 'module1.module2.module3'
for python 3 imp is deprecated, and the best choice is to use importlib's find_spec and then load_module, but importlib module has changed between 3.3 and 3.4 (new methods was added, some became deprecated).
So if implement this then there will be deprecated code or a lot of code to handle different import libraries for different python version.
IMHO current solution is hackish, but works and doesn't require a lot of code. so it's more robust

from nameko.

rochacbruno avatar rochacbruno commented on July 23, 2024

what about werkzeug.utils.import_string?

from nameko.

mattbennett avatar mattbennett commented on July 23, 2024

@rochacbruno, werkzeug.utils.import_string looks ideal

from nameko.

davidszotten avatar davidszotten commented on July 23, 2024

from what i can see, import_string doesn't help distinguishing missing modules from existing modules with bad imports

from nameko.

mattbennett avatar mattbennett commented on July 23, 2024

Ah, I had misremembered what the problem was here. Sadly, werkzeug.utils.import_string doesn't help. You still just get an ImportError.

from nameko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.