A name_update of 1023 chars and domain is lost about namecoin-legacy HOT 12 CLOSED

This line should not return false :
https://github.com/khalahan/namecoin/blob/1f2421d531c74fe290ff5bac90d9d528070b48e6/src/script.cpp#L1158

from namecoin-legacy.

A name_update will fail if previous value was more than 520 characters... Sad...
See http://dot-bit.org/forum/viewtopic.php?f=2&t=503

from namecoin-legacy.

This bug should be marked critical, IMO -- I've personally "lost" a few names because of this bug. A simple fix is to just reject input in both name_firstupdate() and in name_update() that is > 519 bytes. Also, namecoin documentation should reflect this limit instead of saying 1023 bytes.

Also, can someone share more details on the bug here? So others (including me) can try to fix the bug in namecoin itself? Thanks,

from namecoin-legacy.

Are we good on this by now?

from namecoin-legacy.

I think the consensus is that we should add the check to name_firstupdate and name_update to disallow too long values (according to snailbrain, there's already a check in the UI). The fork for actually allowing values up to 1023 bytes (if we really want that?) will be done later when we have discussed value length & fees a bit more.

@muneeb-ali: AFAIK, the problem is that Bitcoin's scripting system doesn't allow values larger than 520 bytes on the stack and fails when it encounters them. This leads to a failing signature check in the name_update if the name's value (which is part of the tx output script) is too large.

from namecoin-legacy.

BTW, can someone confirm what the actual maximum allowed length is? 519 bytes? 520 bytes? Then I will add the check to the RPC commands.

from namecoin-legacy.

Note that this was 'fixed' in the sense that the RPC commands now verify their input and only allow values up to (including) 520 characters. Should we close this issue?

from namecoin-legacy.

Maybe we should discuss this first on the forum...

from namecoin-legacy.

I would support closing this. The risk of losing a name is resolved, and increasing the value size is a much more complex issue that should be discussed separately.

from namecoin-legacy.

agree, close it

from namecoin-legacy.

Closing, thanks Ryan.

from namecoin-legacy.

For the record: values of up to 1023 can be created but after that the name must expire.

from namecoin-legacy.