Cannot see some fields in prometheus metrics about envelop HOT 5 CLOSED

Please share a reproduction on CodeSandbox or StackBlitz. Thanks!

from envelop.

Hello @ardatan I just finished to copy my config on StackBlitz and the error keep occuring: https://stackblitz.com/edit/node-g1tdag?file=index.ts

The /graphql route let you do a simple query and the /test route gives you access to the metrics the plugin collects.

Tell me if something is not clear. I am looking into the plugin source code to see if there is something missing.

from envelop.

contextFactory is missing here. It is usually needed for the plugin's internals;
https://github.com/n1ru4l/envelop/blob/main/examples/express-graphql/index.ts#L28

      const {
        parse: customParseFn,
        validate: customValidateFn,
        execute: customExecuteFn,
        schema: envelopedSchema,
+       contextFactory,
      } = sentryEnvelop({
        req: request,
        res: response,
      });

      return {
        schema: envelopedSchema,
        rootValue: root,
+       context: await contextFactory(),
        graphiql: true,
        customParseFn,
        customValidateFn,
        customExecuteFn,
      };

from envelop.

All right! When using only the contextFactory it works on my side but the thing is that I also have a custom context. I guess I can concatenate them but this does not seem to work. I am still investigating but at least I see that this contextFactory was the missing part.

from envelop.

You can pass your your context to getEnveloped;

getEnveloped({ req, res, myStuff })

from envelop.