Giter Club home page Giter Club logo

Comments (4)

 avatar commented on May 30, 2024

This is working better -- with a 'replyTo' line added into the params array right after the "from" line.

Mail is now seems to be being delivered reliably with this form -- including gmail from-addresses. And can still reply to the sender by clicking "reply". However, I'm not getting the 'name' to show up in either of these for some reason. I'm not super familiar with Kirby, so I'm not 100% sure how this is working. That would be preferable to get the send name to show in the "from" line with the host domain. I just hardcoded the hosting domain for a quick fix, but it would be best to make that dynamic obviously -- one of the kirby url functions maybe with preg replace or something?

'from'        =>   a::get($this->data, 'name', '') . ' <[email protected]>',
'replyTo'   =>   a::get($this->data, 'name', '') . ' <' . a::get($this->data, '_from') . '>',

Thanks for your great work on this plugin. I realize I may be missing something that caused me to have this problem in the first place -- and you've dealt with it in some way that I don't see here.

from kirby-uniform.

mzur avatar mzur commented on May 30, 2024

I totally agree, replyTo would be a better field for the submitter's email address. I'd prefer not to generate the from address directly from the domain name since the user should decide which of their email adresses they want to take. It can be an additional (required) argument in the email array.

As to why the name does not appear I found that it is intentionally removed by the Email class. I guess we could open an issue at the toolkit repo and ask if this can be fixed or we could write our own email service that adds the name to the header again.

from kirby-uniform.

mzur avatar mzur commented on May 30, 2024

Opened a new issure for the names.

from kirby-uniform.

 avatar commented on May 30, 2024

Thanks, Martin. This looks good to me -- handling the sender in the setup array to give users some flexibility.

This plugin is looking really good, by the way. Glad you renamed it in v.2, because it's potentially a lot more than a "contact form." :)

from kirby-uniform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.