Comments (5)
Thanks for the patches! A few things:
- Please use pull requests and isolated feature branches (your master also has other stuff in it), makes it much easier for me to review stuff : ).
- I don't know if this should be in there:
Client.SOCKET_PATH = '/var/run/mysqld/mysqld.sock';
Seems like that's just specific to your system, no? - Wasn't it possible to do this already by setting port = '/some/socket.sock' ? I'm not saying there shouldn't be an explicit property for it, but I was under the impression that this was already working.
- When adding a property to an object (self.unixSocket), always add it in the constructor as well. Otherwise future-me is going to have a hard time reasoning about the state and configuration of the Client object.
--fg
--fg
from mysql.
- Sorry, I'm quite new to Github (and Git for that matter ...). I'll try to learn branching in future. ;)
- In mysql_version.h MYSQL_UNIX_ADDR in defined as "/var/run/mysqld/mysqld.sock". The path conforms the Filesystem Hierarchy Standard, which Linux and *BSD conforms to. So likely even Mac OSX will have the socket at this path.
- Yes it was already possible. I only want to suggest to promote this feature as it promises a remarkable performance gain on low and high frequented web applications.
- You're right. On second thought I'd discourage adding a new parameter. The name
port
for the socket path should be pretty sufficient as is.
My suggestions collapse to proposing making using the unix socket default.
Regards, René
from mysql.
My suggestions collapse to proposing making using the unix socket default.
Hm, I think connecting to localhost:3306 is more common by default, no? But I think I'd like to see a patch that allows:
// Use default: /var/run/mysqld/mysqld.sock
client.socket = true;
Or
client.socket = '/my/custom.sock';
--fg
PS: I'll be on vacation until the 29th, so I won't have a chance to merge anything until then.
from mysql.
host = whatever; port = "/path/to/mysqld.sock"
seems to work perfectly
from mysql.
Use what @dresende for 0.9.x. 2.0.0 now supports this explicitly: 89dd8ab
from mysql.
Related Issues (20)
- 腾讯云系统centos7.2安装mysql失败,怎么办麽、 HOT 1
- Error connecting to Aurora DB using the "Amazon RDS" profile HOT 4
- mysql.createPool transaction with loop HOT 1
- Error: ER_NOT_SUPPORTED_AUTH_MODE: Client does not support authentication protocol requested by server; consider upgrading MySQL client HOT 1
- How to catch ER_BAD_FIELD_ERROR HOT 2
- Missing information in Documentation HOT 1
- Multiple insert using array notation HOT 1
- Uncaught exception for "Connection lost: The server closed the connection." HOT 3
- Node 17.4, MySQL Server 8.0, Mac OS Monterey, ECONNREFUSED with error code -61, ::1:3306 HOT 5
- breaks scope HOT 3
- Supported MySQL Versions HOT 2
- readable stream does not seem to support readableLength property HOT 14
- Question - Get query of row HOT 2
- Write cluster failover, pool stuck with read-only cluster HOT 1
- The correct table name when creating the table, with an error: ER_WRONG_TABLE_NAME. HOT 4
- Better type casting of BIT values HOT 3
- the connection string is parsed wrongly HOT 1
- Updating URL parsing to WHATWG URL HOT 2
- RangeError: The value of "offset" is out of range. It must be >= 0 and <= 5254. Received 5261
- getConnection always get timed out
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mysql.