Giter Club home page Giter Club logo

Comments (6)

rjonaitis avatar rjonaitis commented on July 19, 2024

I agree, the reference clock can be moved to IConnection.

Some notes about reference clocks:

  • SXR and SXT can have separate reference clocks, but it is most likely that they always will be set to identical values.
  • CGEN reference clock is always equal to SXR reference clock.
  • Fixed reference clock boards can depend from used crystal. There are EVB7 boards that use one of the 30.72MHz or 52MHz crystal.

Also it would be a good idea to match units in the APIs, so possibly switch from MHz to Hz.

from limesuite.

guruofquality avatar guruofquality commented on July 19, 2024

SXR and SXT can have separate reference clocks, but it is most likely that they always will be set to identical values.

Right the XBUF config can have different clocks in some configurations. Perhaps we can have an additional set of calls

  • GetTxReferenceClockRate() //without overloading, calls GetReferenceClockRate()
  • SetTxReferenceClockRate() //without overloading, calls SetTxReferenceClockRate()

Also it would be a good idea to match units in the APIs, so possibly switch from MHz to Hz.

I have made a mistake sometimes with the Hz vs MHz. :-) I like to have absolute units when possible. Hz would be preferable in my opinion.

from limesuite.

rjonaitis avatar rjonaitis commented on July 19, 2024

Since the parameters will be changed to Hz, we might as well change the frequency parameter types from float to int64_t.

from limesuite.

guruofquality avatar guruofquality commented on July 19, 2024

I dont know if using a 64-bit integer is worth the trouble. Like: we might end up with strange precision issues when representing frequencies with repeating decimals, like 33.333... MHz. And we would loose the ability to represent sub-hz frequencies, like CORDIC precision. Maybe in reality, this isnt such a problem but I would stick with double for all units (Hz, volts, dB, etc) unless efficiency required it.

from limesuite.

guruofquality avatar guruofquality commented on July 19, 2024

Use ref freq API: 72c316b

from limesuite.

guruofquality avatar guruofquality commented on July 19, 2024

And using Hz has its own issue: #39

Closing

from limesuite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.