Update SDK to support Illuminate/support 7.x branch (and Laravel 7.x) about sdk HOT 15 CLOSED

My current solution is terrible and ugly as ... but it works for the time being.

Implement the above changes to the Collection.php file. Store the file somewhere IN your project (i use resources/MyParcel/Collection.php)
Collection.txt

After deploy of your code to the server, overwrite the Collection.php file in the vendor folder

cp resources/MyParcel/Collection.txt ./vendor/myparcelnl/sdk/src/Support/Collection.php

from sdk.

We are still having this issue on laravel/framework (v7.10.3) with myparcelnl/sdk (v4.0.0):

Fatal error: Declaration of MyParcelNL\Sdk\src\Support\Collection::when($value, callable $callback, ?callable $default = NULL) must be compatible with Illuminate\Support\Collection::when($value, ?callable $callback = NULL, ?callable $default = NULL) in /vendor/myparcelnl/sdk/src/Support/Collection.php on line 486

from sdk.

Having this issue as well.

from sdk.

Saw that part of this is fixed by 648c7db. Except that Illuminati v7.5.2 is moving further and has changed the declaration of the when call:

Fatal error: Declaration of MyParcelNL\Sdk\src\Support\Collection::when($value, callable $callback, ?callable $default = NULL) must be compatible with Illuminate\Support\Collection::when($value, ?callable $callback = NULL, ?callable $default = NULL) in /app/vendor/myparcelnl/sdk/src/Support/Collection.php on line 38

Maybe make two tags when it gets merged into master to let people lock down a combination of myparcel+illuminate in their composer.json?

from sdk.

This is resolved in version 4.0.0. @appelflap @JBtje @Cannonb4ll Can you test whether it works now?

from sdk.

Tried to update, but the 4.x isn't on packagist yet @reindert-vetter

from sdk.

Hi @appelflap ,
When I look on packagist I see version 4.0.0 there, would you like to try again?

from sdk.

Yes, see it now too. Page says: This package is not auto-updated. Last update: 2020-05-08 10:25:13 UTC

Looks good! Stable with:

illuminate/http (v5.6.0 => v7.10.3)
symfony/event-dispatcher (v4.2.12 => v5.0.8)

from sdk.

@RickJeroen, do you also have illuminate/support v7.10.3? Because MyParcelNL\Sdk\src\Support\Collection (indirectly) implements the EnumerateValuesTrait from that package andhas function definition public function when($value, callable $callback = null, callable $default = null) without the optional '?' sign.

from sdk.

@appelflap @RickJeroen @JBtje Do you like or dislike the fact that we extend the standard laravel class? It does force us to stay up to date with the latest changes in Laravel collection

from sdk.

No problems with it being extended, but the dependency is not in the project composer.json. So version compatibility is somewhat unclear.

from sdk.

No problems with it being extended, but the dependency is not in the project composer.json. So version compatibility is somewhat unclear.

I agree

from sdk.

No problems with it being extended, but the dependency is not in the project composer.json. So version compatibility is somewhat unclear.

agree as well

from sdk.

Just tested #230, it works for laravel 7.4-7.11 (latest). Though, as stated by Appelflap, adding dependency requirement in composer.json would be nice.

from sdk.

Still having the same error, have not tried #230 but would be nice if that got merged.

PHP Fatal error:  Declaration of MyParcelNL\Sdk\src\Support\Collection::when($value, callable $callback, ?callable $default = NULL) must be compatible with Illuminate\Support\Collection::when($value, ?callable $callback = NULL, ?callable $default = NULL) in /Users/dennissmink/Workspace/package-dev/vendor/myparcelnl/sdk/src/Support/Collection.php on line 486

from sdk.