Giter Club home page Giter Club logo

Comments (3)

adnaan avatar adnaan commented on July 17, 2024

Hey there. Could you please provide me an example code for the buggy behaviour ?

from pipeline.

liuchenailq avatar liuchenailq commented on July 17, 2024

When I run the sample code you gave, the sample code is pipeline/examples/advanced/main.go

The sample code creates a pipeline with three stages. The first stage is executed sequentially, the second and third stages are executed concurrently, and the first step of the third stage returns an error.

I found that the first stage executed sequentially worked well, while the second and third stages executed concurrently failed, running the last step three times in both cases.

The result is as follows，You can find that stage1 and stage2 both run step2, and run it three times.

[pipeline][getfiles]: begin
[stage-0][stage]: begin
[stage-0][stage]: is not concurrent
[step-0][getfiles.con_stage.*main.downloadStep]: begin
[step-0][getfiles.con_stage.*main.downloadStep]: &{Data:<nil> KeyVal:map[]}
[step-0][getfiles.con_stage.*main.downloadStep]: Started downloading file 1mbfile
[step-0][getfiles.con_stage.*main.downloadStep]: Successfully downloaded file 1mbfile
[step-0][getfiles.con_stage.*main.downloadStep]: end
[step-1][getfiles.con_err_stage.*main.downloadStep]: begin
[step-1][getfiles.con_err_stage.*main.downloadStep]: &{Data:{bytesDownloaded:102400} KeyVal:map[bytesDownloaded:102400]}
[step-1][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 5mbfile
[step-1][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 5mbfile
[step-1][getfiles.con_err_stage.*main.downloadStep]: end
[step-2][getfiles.con_err_stage.*main.downloadStep]: begin
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:{bytesDownloaded:102400} KeyVal:map[bytesDownloaded:102400]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[stage-0][stage]: end
[stage-1][con_stage]: begin
[stage-1][con_stage]: is concurrent
[step-0][getfiles.con_stage.*main.downloadStep]: begin
[step-1][getfiles.con_err_stage.*main.downloadStep]: begin
[step-2][getfiles.con_err_stage.*main.downloadStep]: begin
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:{bytesDownloaded:102400} KeyVal:map[bytesDownloaded:102400]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:{bytesDownloaded:102400} KeyVal:map[bytesDownloaded:102400]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:{bytesDownloaded:102400} KeyVal:map[bytesDownloaded:102400]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[stage-1][con_stage]: end
[stage-2][con_err_stage]: begin
[stage-2][con_err_stage]: is concurrent
[step-0][getfiles.con_err_stage.*main.downloadStep]: begin
[step-1][getfiles.con_err_stage.*main.downloadStep]: begin
[step-2][getfiles.con_err_stage.*main.downloadStep]: begin
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:<nil> KeyVal:map[]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:<nil> KeyVal:map[]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: &{Data:<nil> KeyVal:map[]}
[step-2][getfiles.con_err_stage.*main.downloadStep]: Started downloading file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[step-2][getfiles.con_err_stage.*main.downloadStep]: Successfully downloaded file 10mbfile
[step-2][getfiles.con_err_stage.*main.downloadStep]: end
[stage-2][con_err_stage]: end
[pipeline][getfiles]: end
timeTaken: 9.252079992s

Looking at the source code, I found that the stage.run() function uses closure functions, which I guess is where the bug came from.

// Run the stage execution sequentially
func (st *Stage) run(request *Request) *Result {
	if len(st.Steps) == 0 {
		return &Result{Error: fmt.Errorf("No steps to be executed")}
	}
	st.status("begin")
	defer st.status("end")

	if st.Concurrent {
		st.status("is concurrent")
		g, ctx := withContext(context.Background())
		for _, step := range st.Steps {
			step.Status("begin")
			g.run(func() *Result {

				defer step.Status("end")
				//disables strict mode. g.run will wait for all steps to finish
				if st.DisableStrictMode {
					return step.Exec(request)
				}

from pipeline.

glaye avatar glaye commented on July 17, 2024

Have you solved it?

from pipeline.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.