Giter Club home page Giter Club logo

Comments (7)

oliverklee avatar oliverklee commented on August 11, 2024

It looks like the first tr has no closing tag in the original source. Could you please try what happens if you properly close the tag?

from emogrifier.

Kipperlenny avatar Kipperlenny commented on August 11, 2024

fixed and tried my code - still the same problem (copy & paste mistake....)

from emogrifier.

oliverklee avatar oliverklee commented on August 11, 2024

Could you please try to reduce the HTML and CSS to the absolute minimal test case that still produces the problem? Or, even better, pour it into a (failing) unit test?

from emogrifier.

Kipperlenny avatar Kipperlenny commented on August 11, 2024

Well, the test side http://www.pelagodesign.com/sidecar/emogrifier/ cannot reproduce the error (anymore), I will close this ticket - but we had to fix it with commenting out https://github.com/jjriv/emogrifier/blob/master/Classes/Emogrifier.php#L348 - L355. Otherwise we have empty tr in our mails...

from emogrifier.

oliverklee avatar oliverklee commented on August 11, 2024

Thanks for the feedback. Now I'm confused: Is the problem still present in the latest version available from GitHub, or do we still need to fix it?

from emogrifier.

Kipperlenny avatar Kipperlenny commented on August 11, 2024

:D I cannot reproduce it anymore on the emogrifier testsite - but we still have the problem on our system. Perhaps because of a sideeffect in the html - it was not possible for me to trac the html down to a minimal version.... And I have no time for that atm - we have our workaround (like discribed above) and the customer is happy :)

Perhaps I will have time sooner or later to recheck.... but not at the moment.

from emogrifier.

oliverklee avatar oliverklee commented on August 11, 2024

Okay. If you have more information, please feel free to reopen this ticket. Thanks for reporting the issue!

from emogrifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.