maven plugin does not interpolate system properties when creating generator configuration about generator HOT 5 CLOSED

Well this is a tricky one. You are correct that the system properties are not included in the project properties. I think the best way to fix this is to create a consolidated properties object that adds the system properties to the project properties. This means that if a system property has the same name as a project property, the system property will override the project property. I believe is what the normal intention would be.

from generator.

I'm not that into maven to know if there's a proper maven api to achieve this, but I can manage to use the java api to access the system properties and propose a fix.

I need some guidance on how to properly write a test for this scenario so that the fix can be tested.

from generator.

I think I want to make a change in the base generator code to deal with this. There are actually three sets of properties: the Maven (or Ant) properties, the properties loaded from the configuration element, and then the system properties. There should be some kind of hierarchy for deciding which one wins if there is a name collision. I think this priority makes sense:

1. System Properties
2. properties
3. Maven or Ant properties

Meaning that system properties will always win if there is a collision.

BTW - I've spent some time with the Maven plugin test harness and it's a lot of work for not much payback. If I make the change in the base generator code it will be easier to write some tests.

from generator.

Ok, great, the order you propose definitely makes sense to me.
Let me know if I can help in some way.
Thanks

from generator.

I did some manual testing for this and I believe I have it correct. Let me know if there is any issue for you in your environment.

from generator.