Giter Club home page Giter Club logo

Comments (10)

kapilharesh avatar kapilharesh commented on September 26, 2024 1

Sure - fair enough.

What I can probably do is open a branch based off master, and keep them there but just not merge it till the time comes.

from www.

kapilharesh avatar kapilharesh commented on September 26, 2024 1

Files have been temporarily kept in the image-upload branch, so whenever you are all ready to merge it should be able to fit into master without much trouble (as it is fully contained in the public directory).

from www.

kapilharesh avatar kapilharesh commented on September 26, 2024

Should organize this folder by story submitter type.

  1. Essential worker - https://unsplash.com/collections/50714126/my-covid-story---essential-worker/0f8889be4663e9fbaa50a23ebabf281e
  2. Healthcare - https://unsplash.com/collections/2203103/my-covid-story---healthcare/41b52cb8be6e07c52a2a747d5fac391e
  3. Education - https://unsplash.com/collections/93463902/my-covid-story---education/28490297d617289d22dcdeeb37708fde
  4. Small business - https://unsplash.com/collections/99966874/my-covid-story---small-business/1c64fa519b96ae4cea057a34001fb54c
  5. Patients & Family - https://unsplash.com/collections/64078744/my-covid-story---patients-%26-family/30e26b50e940f83a29b4fcf495428fb6

from www.

davesteinberg avatar davesteinberg commented on September 26, 2024

For first release, I'm doing a single image per category, as decided here: https://mycovidstoryworkspace.slack.com/archives/C01UF760UG6/p1618934969097100

When we start using a random selection from the sets, we'll need to assign an image at story creation time and add an identifier to the database, so that we always use the same image for each story.

from www.

mwickett avatar mwickett commented on September 26, 2024

@kapilharesh Are you still able to tackle this?

from www.

davesteinberg avatar davesteinberg commented on September 26, 2024

@mwickett To be clear, I've added one image per category and implemented showing them in the feed and single-story pages (not yet committed).

The multiple images per category and assigning an identifier at story creation, that's to be done post 1.0, I think.

Also, there weren't any collections for Concerned Citizen or Other, so I used a couple of the more generic images from the Patients & Family collection.

from www.

kapilharesh avatar kapilharesh commented on September 26, 2024

Oops this slipped past me. I can have the photos added to the public dir in a bit. @davesteinberg how is your code referencing the images right now? Are you hard coding the file names (and if so what are those names again?)

from www.

davesteinberg avatar davesteinberg commented on September 26, 2024

@kapilharesh Sorry, no, let's please not add the collections of images until we have the logic in place to use them.

I'm just about to open a PR with my big changes, including adding the one-per-category images that they use.

from www.

davesteinberg avatar davesteinberg commented on September 26, 2024

Good idea. Thanks!

from www.

silent1mezzo avatar silent1mezzo commented on September 26, 2024

Moving out of milestone.

from www.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.