Comments (10)
Sure - fair enough.
What I can probably do is open a branch based off master, and keep them there but just not merge it till the time comes.
from www.
Files have been temporarily kept in the image-upload
branch, so whenever you are all ready to merge it should be able to fit into master without much trouble (as it is fully contained in the public directory).
from www.
Should organize this folder by story submitter type.
- Essential worker - https://unsplash.com/collections/50714126/my-covid-story---essential-worker/0f8889be4663e9fbaa50a23ebabf281e
- Healthcare - https://unsplash.com/collections/2203103/my-covid-story---healthcare/41b52cb8be6e07c52a2a747d5fac391e
- Education - https://unsplash.com/collections/93463902/my-covid-story---education/28490297d617289d22dcdeeb37708fde
- Small business - https://unsplash.com/collections/99966874/my-covid-story---small-business/1c64fa519b96ae4cea057a34001fb54c
- Patients & Family - https://unsplash.com/collections/64078744/my-covid-story---patients-%26-family/30e26b50e940f83a29b4fcf495428fb6
from www.
For first release, I'm doing a single image per category, as decided here: https://mycovidstoryworkspace.slack.com/archives/C01UF760UG6/p1618934969097100
When we start using a random selection from the sets, we'll need to assign an image at story creation time and add an identifier to the database, so that we always use the same image for each story.
from www.
@kapilharesh Are you still able to tackle this?
from www.
@mwickett To be clear, I've added one image per category and implemented showing them in the feed and single-story pages (not yet committed).
The multiple images per category and assigning an identifier at story creation, that's to be done post 1.0, I think.
Also, there weren't any collections for Concerned Citizen or Other, so I used a couple of the more generic images from the Patients & Family collection.
from www.
Oops this slipped past me. I can have the photos added to the public dir in a bit. @davesteinberg how is your code referencing the images right now? Are you hard coding the file names (and if so what are those names again?)
from www.
@kapilharesh Sorry, no, let's please not add the collections of images until we have the logic in place to use them.
I'm just about to open a PR with my big changes, including adding the one-per-category images that they use.
from www.
Good idea. Thanks!
from www.
Moving out of milestone.
from www.
Related Issues (20)
- Update schema for SEO HOT 2
- What about adding commitlint?
- Paginate story feed HOT 4
- 404 page with undraw svg HOT 2
- Make all navigation elements Next links HOT 1
- Go all in on plain text - swap out `sanitize-html` with a plain text sanitizer HOT 2
- Trim social share description content to closest sentence end. HOT 3
- SSG issues HOT 6
- Headings needs to be checked for symbols HOT 2
- Update FAQ to reflect improved story moderation requirements
- Provide filtering for the story feed HOT 1
- Previous and next links on story view HOT 1
- Nav drawer animation jank
- Update to FAQ page content HOT 1
- Display some high level site metrics on the home page HOT 2
- Allow users the ability to choose their preferred background image from a collection of stock images
- Invalid HTML on FAQ page: <p> cannot appear as a descendant of <p>
- Replace current tagline on homepage HOT 1
- Update website copy based on new mission and goals
- Media page with links to our media coverage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from www.