Giter Club home page Giter Club logo

Comments (4)

d-Pixie avatar d-Pixie commented on June 18, 2024

Yes, I had some problem with this in the original design. If I remember correctly some part of this flow is forced to be synchronous by Chrome, ie. we can't return a promise, I think it was the request intercept. Makes sense since the request could otherwise hang indefinitely waiting for some before filter to resolve.
That forced me to use a synchronous load of the remote payload. If there is a new way of solving this I'm all ears. At the time there was not...

from tiff-viewer-extension.

Pheil avatar Pheil commented on June 18, 2024

Here is my tweaked/condensed background.js if it generates any ideas for you. This probably could be fixed to replace the image with the data:image instead of the blob, but I wasn't expecting to run into the two bugs as I was tweaking it.
background.txt

from tiff-viewer-extension.

d-Pixie avatar d-Pixie commented on June 18, 2024

I'll have a look at it when I have some time. What bugs did you encounter?

from tiff-viewer-extension.

Pheil avatar Pheil commented on June 18, 2024

I put comments in the code for these two. Basically I changed it to asynchronous then was trying to use a blob instead of the data:url since the blob links open so much faster,

https://bugs.chromium.org/p/chromium/issues/detail?id=446453
//Cannot redirect to blob in Chrome or FF
https://bugzilla.mozilla.org/show_bug.cgi?id=1256122
//Due to this bug, redirect to blank tab and open blob in new tab.

from tiff-viewer-extension.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.