Giter Club home page Giter Club logo

Comments (3)

equinusocio avatar equinusocio commented on July 29, 2024 2

Just edit the provided css or use your own classes.

from sharingbuttons.io.

olets avatar olets commented on July 29, 2024

Google's PageSpeed Insights recommends primary tap targets be at least 7mm x 7mm (approx. 48 css pixels), with 5mm space (32 css pixels) separating them from other tap targets.1.

The buttons are currently 20px tall separated 16px. @mrnagy88 this isn't going to impact SEO, at least with Google

Technically speaking, Google does not use the PageSpeed Insights tool to determine search engine ranking (but may do in the future).

but if we take their recommendation to heart it could be good to make the tap targets bigger and more spaced out on mobile with a @media query. The larger tap target could be a larger visible button, or adding (transparent, clickable) padding to the links, or (my intuition is this would be best) a little of both. Submit a PR?

1 https://developers.google.com/speed/docs/insights/SizeTapTargetsAppropriately

from sharingbuttons.io.

mrnagy88 avatar mrnagy88 commented on July 29, 2024

I'm not sure but I got an error in an SEO report, I suspect it might be the little dashes that appear when you hover that is creating the error message then, or the way I had it set up on my page perhaps with other links nearby. Have you seen those hidden dashes?

Here is an example with the dashes:
http://www.cosmoscondovip.ca/
When you include that invisible tap target space the links are essentially touching

I see now it's a CSS underline that's set on all <a> links on my page only. Still are the tap targets supposed to touch like that?

from sharingbuttons.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.