Comments (1)
You're right: there are no weak
references in the project.
Actually there many strong
reference cycles, I found a few just by looking at the AppDependencies.swift
file (e.g. ListPresenter
and ListWireframe
reference to each other, same for ListPresenter
and ListInteractor
, and AddWireframe
and AddPresenter
).
Some of these references (most of them) are optionals, but they still are strong
references.
The ideal would be to have the ListViewController
to strong
reference the ListPresenter
, and all the other references to ListPresenter
weak
(from ListWireFrame
, ListInteractor
, and AddPresenter
).
Therefore when the VC is deinitialized you have a chain-reaction where every other part of the VIPER architecture for that view is deinitialized.
The problem in this project is that the ListviewController
is initialized after the dependencies are already set up, therefore what I suggest above is not implementable without some code changes (that are more than just adding weak
here and there).
from viper-swift.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from viper-swift.