Comments (4)
Hi, good suggestion. I wrote here when they are not compatible. As for ATD, I also added the empty tensor, so spandrel could detect it.
what your take is on neosr models being incompatible with original arch code?
If the changes contributes that much, yes, I would accept it. Minor changes should be an option though, as we have been doing with rgb normalization. For example, in some networks I added flash attention, because it improves ~40% training speeds. However, I made it a bool param, so anybody can enable/disable it.
from neosr.
Just one thing: you forgot SPAN :)
Added it
Maybe it's detectable?
Not sure, but probably yes. I put 2 models in this zip, one with flash_attn: true
and other without it, if you want to take a look at some point: flash_attn.zip
from neosr.
I put 2 models in this zip
Thanks! That'll help when I get to it.
Since all architectures modifications seems to have been documented, I consider this issue closed now. We have to investigate those modifications for spandrel, but that isn't an issue with neosr.
Thanks musl!
from neosr.
I wrote here when they are not compatible.
Lots of valuable information. Thanks! Just one thing: you forgot SPAN :)
I'll have some testing to do to see how compatible everything is with spandrel.
As for ATD, I also added the empty tensor, so spandrel could detect it.
Yup, I saw. I'll add support for this soon.
I added flash attention
I wonder how compatible that is. You don't seem too optimistic in the docs. Maybe it's detectable? Then it won't be an issue. Well, I guess I'll just have to intestate and see.
from neosr.
Related Issues (20)
- wrapper around train.py, ... scripts and release on pypi
- `train_realesrgan.yml` is named "train_esrgan" HOT 1
- imwrite raise IOError when trying to write an image where the filename contains unicode characters HOT 2
- How to save a model fully in pth? Not state dict HOT 3
- Add tile option HOT 2
- Modifications for CRAFT, SwinIR, and DCTLAS are not detectable HOT 8
- Automatically remove old checkpoints and visualizations HOT 4
- and again rgb_mean HOT 1
- assets HOT 3
- dataset_enlarge_ratio description HOT 1
- Mismatched resume state issue HOT 1
- All architectures with `rgb_mean = (0.5, 0.5, 0.5)` are incompatible HOT 9
- Python version problem HOT 4
- Question regarding net_d HOT 4
- model zoo HOT 1
- can not start train HOT 3
- GPU memory not fixed when training HOT 1
- ValueError at 79 epoch HOT 3
- NaN errors occurring constantly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neosr.