Import not appearing for some Discogs releases (box sets?) about musicbrainz-userscripts HOT 6 CLOSED

Likewise, can't figure it out...

from musicbrainz-userscripts.

Looking at this again, I think I see three problems:

The first problem is that for box sets, the first format is "Box Set". This doesn't map to a medium format in MusicBrainz, so I think it should probably be ignored on line 308.

The second, related to the previous one, is that on line 308, if it fails to map the Discogs format to a MusicBrainz format, it adds a null value to the array of formats. Then via line 426, line 430 tries to use match() on the null value, which fails and prevents the import button from being shown.

The other problem - I think - is that that release reuses A and B for every medium, and on line 407 it seems to be using the letters to determine the medium number. A and B both end up as medium 1, which I think is why when the problem above is fixed, you get one long medium here instead of four. In #15, the same code causes two mediums to be added, because the last tracks start with "D".

from musicbrainz-userscripts.

Here are some more examples:

http://www.discogs.com/release/3129043
http://www.discogs.com/release/157972
http://www.discogs.com/release/119886
http://www.discogs.com/release/3302638

from musicbrainz-userscripts.

All 4 of the releases in the previous comment now show an import button, for the record.

I have two releases where a button never shows. I'm in Chrome OSX + Tampermonkey and see buttons on almost all releases.

http://www.discogs.com/Various-When-We-Were-Things-Part-1/release/73531
http://www.discogs.com/Joy-Orbison-Boddika-Trickys-Team/release/5609148

Let me know if it's appropriate for me to add any other releases with this problem to this ticket.

from musicbrainz-userscripts.

The issue with http://www.discogs.com/Joy-Orbison-Boddika-Trickys-Team/release/5609148 is that the buttons aren't shown because script failed to insert them due to the lack of the usual social section, it isn't a particular issue with the release itself.
Fixed by 30be1ef

The http://www.discogs.com/Various-When-We-Were-Things-Part-1/release/73531 issue was fixed too by a previous commit: 1bf80fb

Please create one issue per problematic link, it will ease things ;)

from musicbrainz-userscripts.

Original issue partially fixed with 9b8a8ef

As correctly explained by @96187 there are 2 issues :

1. the first one is that we were trying to tread "Box-set" as a medium format <= issue fixed with the commit
2. the second one is that release reuses A1 track number for the 2nd medium <= this is not handled by the import script, my position is that discogs data should be fixed instead.

from musicbrainz-userscripts.