Comments (5)
From [email protected] on September 07, 2010 10:25:48
This review seemed to omit the changes submitted in this branch. Please see https://code.google.com/p/munki/source/detail?r=724 for this change.
from munki.
From [email protected] on September 07, 2010 10:32:47
I'm going to need some convincing as to why this code should be merged into updatecheck.py and munkicommon.py, instead of just being a preflight script. A preflight script could dynamically generate a ClientIdentifier using any code the site admin wanted to use. It could then write this "dynamic" ClientIdentifier to ManagedInstalls.plist before returning.
Do you have any example ClientIdentiferPlugins?
from munki.
From [email protected] on September 07, 2010 11:03:25
Previously I did not know about preflights, but yes it appears to fit there nicely. If we find a need to have this in the core code in the future we can remail it then, but I think preflight is the way to go for now.
Currently the only plugin we have is to generate a client id containing machine uuid, hostname, owner, puppet track, etc.
Given that site admins are going to be modifying code, I still feel the security layers around executing are worthwhile. Should I add them to the runPreOrPostFlightScript function to ensure pre/postflight are safe?
from munki.
From [email protected] on September 07, 2010 11:07:55
Yes, adding the security check to runPreOrPostFlightScript() makes sense.
from munki.
From [email protected] on September 07, 2010 11:54:15
Set review issue status to: WontFix
Status: WontFix
from munki.
Related Issues (20)
- Logic error when processing requires items that fail to download HOT 2
- Minor MSC UI issue - Removing app progress HOT 4
- Option to check for items to install only, 'dry run' HOT 1
- MSC 6.2.1.4599 crashes on macOS 10.13 HOT 18
- munkiimport and munkilib/pkgutils.py crash with packages containing .dist file HOT 13
- Preinstall_alerts not being shown for updated software HOT 3
- Placment of the back button in Managed Software Centre HOT 9
- [Feature Request] - Add a Pkginfo Key to skip update check HOT 2
- security issue: Writing sensitive information into log file HOT 3
- Option to ignore unmanaged preferences HOT 4
- Question: Does munki have a client CLI tool for software installation and update HOT 1
- installable_condition crashes client HOT 10
- Application failing to install HOT 1
- Update Python to Version 3.12 HOT 19
- Improve logging for "could not find unique packages to remove for item_name" warnings HOT 7
- TLS Certificat fΓΌr https://munkibuilds.org/ is not correct HOT 5
- When importing bundle packages in macOS 14.4 RestartAction is set incorrectly HOT 3
- GarageBand Loops Wiki needs updating HOT 5
- BUG: Application info removed from info object during updatecheck and breaks conditions that require said info HOT 2
- catalogs data not being collected in ManagedInstallsInfo after 6.5.1.4661 update HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from munki.