Code Review Request: Allow for dynamic Client Identifier generation through custom plugin code. about munki HOT 5 CLOSED

From [email protected] on September 07, 2010 10:25:48

This review seemed to omit the changes submitted in this branch. Please see https://code.google.com/p/munki/source/detail?r=724 for this change.

from munki.

From [email protected] on September 07, 2010 10:32:47

I'm going to need some convincing as to why this code should be merged into updatecheck.py and munkicommon.py, instead of just being a preflight script. A preflight script could dynamically generate a ClientIdentifier using any code the site admin wanted to use. It could then write this "dynamic" ClientIdentifier to ManagedInstalls.plist before returning.

Do you have any example ClientIdentiferPlugins?

from munki.

From [email protected] on September 07, 2010 11:03:25

Previously I did not know about preflights, but yes it appears to fit there nicely. If we find a need to have this in the core code in the future we can remail it then, but I think preflight is the way to go for now.

Currently the only plugin we have is to generate a client id containing machine uuid, hostname, owner, puppet track, etc.

Given that site admins are going to be modifying code, I still feel the security layers around executing are worthwhile. Should I add them to the runPreOrPostFlightScript function to ensure pre/postflight are safe?

from munki.

From [email protected] on September 07, 2010 11:07:55

Yes, adding the security check to runPreOrPostFlightScript() makes sense.

from munki.

From [email protected] on September 07, 2010 11:54:15

Set review issue status to: WontFix

Status: WontFix

from munki.