Giter Club home page Giter Club logo

Comments (14)

Krzmbrzl avatar Krzmbrzl commented on July 26, 2024

it seems that murmur forces itself to foreground mode which logs to the console and not to a file or that something is missing to allow it to write logs.

Aye - that's what is requested from the Dockerfile itself:

CMD ["/usr/bin/mumble-server", "-fg"]

I did not remember this preventing a log file from being written but now that you mention this, I think I stumbled upon this before 🤔

I actually don't quite remember why we start the server in foreground mode here anyway. Presumably to
a) Prevent the container from exiting right after having started the server and
b) Make sure that the log is written to stdout so that you can check on what the server is doing

If it turns out to be impracticable or unnecessary to run in foreground mode, I would not be opposed to removing the -fg parameter and just letting the server run in background mode 👀

from mumble-docker.

azlux avatar azlux commented on July 26, 2024

@Krzmbrzl with docker, you need to keep your program in foreground, this allow docker to follow the run and his state. (for status, restart, starting steps), we should not remove this flag.

The doc say:

-fg Run in the foreground, logging to standard output.

So if mumble isn't capable to copy the ouput into a file in foreground mode, it's not possible to fix this issue.

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on July 26, 2024

Ah okay, I see. I guess in this case it should probably be considered a bug in the upstream code...

@pawlakm the log should also be found in the servers database (in the slog table) so in the meantime youcoukd access it through that.

from mumble-docker.

pawlakm avatar pawlakm commented on July 26, 2024

Thanks for the workaround.
Will you create a request in the upstream code ? Or do I have to do it ?

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on July 26, 2024

Feel free to do it yourself - I'll only forget it xD

from mumble-docker.

pawlakm avatar pawlakm commented on July 26, 2024

Done

from mumble-docker.

pawlakm avatar pawlakm commented on July 26, 2024

Update:

Just found the docker-file-log-driver logging driver plugin. It can be installed using the following command:

docker plugin install deepcompute/docker-file-log-driver:1.0 --alias file-log-driver

Then when adding this to my docker-compose.yml file at the same level as the image block :

        logging:
            driver: file-log-driver
            options:
                fpath: "/mumble-server/mumble-server.log"

I can access mumble-server logs as a json file located in /var/log/mumble-server/mumble-server.log.

Unlike using docker-compose logs -f <service-name> > logs/mumble-server.logs & which requires a manual execution at each container "up", this approach is fully automatic. The logs are a bit verbose, but it does the job.

from mumble-docker.

pawlakm avatar pawlakm commented on July 26, 2024

IMHO using a logging driver should be the preferred approach for retrieving the logs. However this means that MUMBLE_CONFIG_LOGFILE will never be used and people should be aware of that. Mounting a volume for the logs is also useless then.

What do you think ?

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on July 26, 2024

Sounds good to me, but I am also not very experienced in the Docker business. @azlux what's your take on this?

from mumble-docker.

azlux avatar azlux commented on July 26, 2024

You can use a logging driver for a specific service into the docker-compose.
This will allow you to only save mumbler-server log.

I think the bug on the upstream is valid too. At least, mumble should warn the log will not be write because of foreground flag.
Other product like nginx allow you to log into a file AND having the error into the console during foreground run.

from mumble-docker.

StrangePeanut avatar StrangePeanut commented on July 26, 2024

Please don't change this behaviour. This is how most apps work when not allowed to daemonise/fork (ie -fg). Experienced users expect things to work this way. People should do things right and use one of the Docker logging drivers to suit their needs, https://docs.docker.com/config/containers/logging/configure/

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on July 26, 2024

Alright, then I guess everything is working as intended and if anything, this would be a bug report against the upstream repo.

from mumble-docker.

albotroz avatar albotroz commented on July 26, 2024

I searched around to find the SuperUser password after setting up the Mumble server (Docker). Searched and searched the log. Nowhere was one created. Although I explicitly mentioned this in mumble-server.ini.

This "problem" is or was not mentioned anywhere. In no doc or tutorial. I just found this by chance.

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on July 26, 2024

mentioned this in mumble-server.ini.

That's not possible. For the Docker image you have to specify it via a variable as documented in the README of the Docker repo.

from mumble-docker.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.