Giter Club home page Giter Club logo

Comments (3)

amorey avatar amorey commented on May 27, 2024 2

Thanks for the update! I expected to see the error on page load so I got confused initially.

I fixed this bug and published a new version (0.10.3). Now clicking on a tab will activate that tab without triggering the error. I also considered activating the first tab by default if ".mui--is-active" isn't present but that raises other issues that I hadn't considered (e.g. what if related pane is dynamic and isn't present in DOM) so I'm leaning towards leaving it as-is.

Let me know if you run into any more problems with the tabs component!

from mui.

amorey avatar amorey commented on May 27, 2024

It should be fairly easy to modify the JS code to activate the first tab by default when "mui--is-active" is not set. I can take a look at this. In the mean time, can you share some example code to reproduce that error message? I tried the html but I don't see an error message (Chrome/Firefox/Safari):
https://jsfiddle.net/muicss/dku8f2ar/

from mui.

PaulSearcy avatar PaulSearcy commented on May 27, 2024

Tested on: Chrome 83, Firefox 76, Edge 44, Safari 13.1

Your fiddle https://jsfiddle.net/muicss/dku8f2ar/ I get the same error in console (in all browsers listed above).
Clicking on FAQ or Contact Form does nothing.

Uncaught TypeError: Cannot read property 'id' of null
    at s (mui.min.js:1)
    at HTMLAnchorElement.r (mui.min.js:1)

Another thing to note is that I tested Safari 13.1 inside a VM as to rule out some weird esoteric setting on my laptop. 😆

from mui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.