Comments (16)
Yes, we already have this done in the Q4 zip waiting to be deployed.
from mui-design-kits.
Yeah, I think we should do it only once we have our own charts released!
from mui-design-kits.
But actually, maybe we should add charts in Figma before that we add them in React. The Material Design guidelines cover them a bit: https://material.io/design/communication/data-visualization.html. Many Designers seem to crave for it: https://www.figma.com/community/file/855517047816771255.
from mui-design-kits.
@danilo-leal I think that there are compelling arguments for both options. Happy either way.
I'd suppose they're also asking for the charts to be available on code as well...
Could be yes. @adrianmanea feel free to pick the path that resonates the most with you.
from mui-design-kits.
Charts: https://mui.com/x/react-charts/
from mui-design-kits.
That's a great idea. Should it be biased towards a specific style of a Chart API? Which do people use the most nowadays?
@danilo-leal I'd very much want to know your opinion
from mui-design-kits.
I have left the "On hold" label, because we don't really have charts yet. It's not ready to be worked on, it's on a shaping phase right now, but it might come to it.
from mui-design-kits.
Assuming that designers use the Kits because their devs use the React lib, I'd argue: wouldn't the components being available first in the Kits create more noise than signal? I mean, designers would use it in their applications and then the devs would try to search in the lib to find it out that, wait, it's not yet available... So, sorry designers, we can't pull it off exactly as you hoped. And also, for complex components like charts, it seems easier for the Kits to mimic the React implementation than the other way around, doesn't it?
Regardless, it would be cool to have the charts available on the Kit right at the same time when the charts are available in the library, so both audiences would be able to explore and use it together.
from mui-design-kits.
@danilo-leal The design kit could warn that there is no React implementation available, and recommend a few React chart libraries options. I came back to this issue today after seeing this review:
from mui-design-kits.
But this makes me wonder - and this is a good subject to research - are there people using the Design Kits and not using the React library? It's a really strange use case to think about for me. I can imagine people that go to the Kits because they're a more complete set than the MD official ones but even then, what we sell is tailored to be a mirror of our React implementation of the components. And the scenario where designers extract the maximum value out of the Kits is when they have devs using the library, so they share the same language and have no surprises.
By making a component available first on the Design Kits, and then not having it ready for the React lib, and even going further to recommend other libraries, seems to have the potential to upset people, and it seems to even hurt what we say on the Store: "What you design is what you get in production" - in that case, it won't be, at least not necessarily.
I guess we can interpret people asking for components, be it through the Design Kits or the library itself, as a general request for a component. And once the component is available on the main medium - React code - it must be available in all others (Design Kits).
from mui-design-kits.
there people using the Design Kits and not using the React library
We would need to survey to know for sure. I won't expect more than 10%
not having it ready for the React lib
It could be coming from another React library. At least, designers would get some of the pain covered. It's still better than nothing, until we ship our own React chart library, if we ever do.
from mui-design-kits.
It's still better than nothing
Initially, it seems it could be but what I'm questioning is exactly this... is it, really?! We'd be adding a component that is not available in our library, linking another library which we don't have control over and no expertise about it which opens the possibility for the design/dev pair using the Figma library disappointed.
In general, my approach would be adding components to the Design kits only once they're up on the actual library. I wouldn't optimize for the use-case only using the Kits and not the library even though it's possible. I think we provide the greatest value if the designer and developer are synced by using both products. There are already other Figma charts files out there that designers can use. If they're asking us for the charts, I'd suppose they're also asking for the charts to be available on code as well... and if there are that many people asking, it's input for prioritization :)
from mui-design-kits.
According to the loud feedback we've got so far, clients seem to value--how close the design kit is compared to the library itself in terms of component props, paddings, etc. I guess the design kit value is measured in development time at the end of the day, with developers spending less time implementing the mockups.
With that being said, what @danilo-leal has commented is aligning with my proposal as well--keep the design kit as close to the library as possible. Having charts would simply be a nice-to-have feature IMHO. Right now, there are other improvements far more valuable which I'm excited to add 🤓.
from mui-design-kits.
I guess the design kit value is measured in development time at the end of the day, with developers spending less time implementing the mockups.
Great observation and insight on measuring the Design Kits success :)
from mui-design-kits.
@adrianmanea Should we add this issue in the roadmap: https://github.com/mui/mui-design-kits/projects/1? Seeing https://twitter.com/shpadrian/status/1721460342981534149 suggests that yes
from mui-design-kits.
Yes, we already have this done in the Q4 zip waiting to be deployed.
cc @DavidCnoops 🙏
from mui-design-kits.
Related Issues (20)
- You have a new comment on Material UI for Figma (and MUI X) by anne.pereira Sterling HOT 1
- 1 editor + 2 designers means 3 licensee? HOT 1
- [question] What's the best to turn content to RTL on Figma? HOT 1
- New comment on YouTube by Tomas Hudolin HOT 1
- [question] What's the best practice for dealing with multiple themes? HOT 1
- You have a new comment on Material UI for Figma (and MUI X) by Diarmuid HOT 1
- [material-ui] Missing Popover component from the UI kit
- [material-ui] Blue 700 value on Figma library doesn't match with node_module value
- New comment on YouTube by Deanne/Stephen Kelly HOT 1
- You have a new comment on Material UI for Figma (and MUI X) by Casper Eisma HOT 1
- [question] List Item: How to change the margin from icon to text in figma? HOT 3
- [material-ui] The color variable for orange 900 does not match the hex code defined in Material Colors HOT 1
- When using components from the imported MUI library it feels like the component controls are not working HOT 2
- You have a new comment on Material UI for Figma (and MUI X) by Tosh HOT 1
- [question] About the Chip icon size on the Joy UI kit HOT 1
- [material-ui] Missing Image Lists component from the UI kit HOT 1
- You have a new comment on Material UI for Figma (and MUI X) by Kate Oh HOT 1
- You have a new comment on Material UI for Figma (and MUI X) by Tosh HOT 1
- You have a new comment on Material UI for Figma (and MUI X) by James Meyer HOT 1
- [figma] Create marketing page, kill https://mui.com/store/items/figma-react/ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mui-design-kits.