Giter Club home page Giter Club logo

Comments (16)

adrianmanea avatar adrianmanea commented on May 19, 2024 2

Yes, we already have this done in the Q4 zip waiting to be deployed.

Screenshot 2024-02-13 at 23 19 35

from mui-design-kits.

danilo-leal avatar danilo-leal commented on May 19, 2024 1

Yeah, I think we should do it only once we have our own charts released!

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024 1

But actually, maybe we should add charts in Figma before that we add them in React. The Material Design guidelines cover them a bit: https://material.io/design/communication/data-visualization.html. Many Designers seem to crave for it: https://www.figma.com/community/file/855517047816771255.

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024 1

@danilo-leal I think that there are compelling arguments for both options. Happy either way.

I'd suppose they're also asking for the charts to be available on code as well...

Could be yes. @adrianmanea feel free to pick the path that resonates the most with you.

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024 1

Charts: https://mui.com/x/react-charts/

from mui-design-kits.

adrianmanea avatar adrianmanea commented on May 19, 2024

That's a great idea. Should it be biased towards a specific style of a Chart API? Which do people use the most nowadays?

@danilo-leal I'd very much want to know your opinion

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024

I have left the "On hold" label, because we don't really have charts yet. It's not ready to be worked on, it's on a shaping phase right now, but it might come to it.

from mui-design-kits.

danilo-leal avatar danilo-leal commented on May 19, 2024

Assuming that designers use the Kits because their devs use the React lib, I'd argue: wouldn't the components being available first in the Kits create more noise than signal? I mean, designers would use it in their applications and then the devs would try to search in the lib to find it out that, wait, it's not yet available... So, sorry designers, we can't pull it off exactly as you hoped. And also, for complex components like charts, it seems easier for the Kits to mimic the React implementation than the other way around, doesn't it?

Regardless, it would be cool to have the charts available on the Kit right at the same time when the charts are available in the library, so both audiences would be able to explore and use it together.

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024

@danilo-leal The design kit could warn that there is no React implementation available, and recommend a few React chart libraries options. I came back to this issue today after seeing this review:

Screenshot 2021-10-29 at 23 12 55

from mui-design-kits.

danilo-leal avatar danilo-leal commented on May 19, 2024

But this makes me wonder - and this is a good subject to research - are there people using the Design Kits and not using the React library? It's a really strange use case to think about for me. I can imagine people that go to the Kits because they're a more complete set than the MD official ones but even then, what we sell is tailored to be a mirror of our React implementation of the components. And the scenario where designers extract the maximum value out of the Kits is when they have devs using the library, so they share the same language and have no surprises.

By making a component available first on the Design Kits, and then not having it ready for the React lib, and even going further to recommend other libraries, seems to have the potential to upset people, and it seems to even hurt what we say on the Store: "What you design is what you get in production" - in that case, it won't be, at least not necessarily.

I guess we can interpret people asking for components, be it through the Design Kits or the library itself, as a general request for a component. And once the component is available on the main medium - React code - it must be available in all others (Design Kits).

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024

there people using the Design Kits and not using the React library

We would need to survey to know for sure. I won't expect more than 10%

not having it ready for the React lib

It could be coming from another React library. At least, designers would get some of the pain covered. It's still better than nothing, until we ship our own React chart library, if we ever do.

from mui-design-kits.

danilo-leal avatar danilo-leal commented on May 19, 2024

It's still better than nothing

Initially, it seems it could be but what I'm questioning is exactly this... is it, really?! We'd be adding a component that is not available in our library, linking another library which we don't have control over and no expertise about it which opens the possibility for the design/dev pair using the Figma library disappointed.

In general, my approach would be adding components to the Design kits only once they're up on the actual library. I wouldn't optimize for the use-case only using the Kits and not the library even though it's possible. I think we provide the greatest value if the designer and developer are synced by using both products. There are already other Figma charts files out there that designers can use. If they're asking us for the charts, I'd suppose they're also asking for the charts to be available on code as well... and if there are that many people asking, it's input for prioritization :)

from mui-design-kits.

adrianmanea avatar adrianmanea commented on May 19, 2024

According to the loud feedback we've got so far, clients seem to value--how close the design kit is compared to the library itself in terms of component props, paddings, etc. I guess the design kit value is measured in development time at the end of the day, with developers spending less time implementing the mockups.

With that being said, what @danilo-leal has commented is aligning with my proposal as well--keep the design kit as close to the library as possible. Having charts would simply be a nice-to-have feature IMHO. Right now, there are other improvements far more valuable which I'm excited to add 🤓.

from mui-design-kits.

danilo-leal avatar danilo-leal commented on May 19, 2024

I guess the design kit value is measured in development time at the end of the day, with developers spending less time implementing the mockups.

Great observation and insight on measuring the Design Kits success :)

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024

@adrianmanea Should we add this issue in the roadmap: https://github.com/mui/mui-design-kits/projects/1? Seeing https://twitter.com/shpadrian/status/1721460342981534149 suggests that yes

from mui-design-kits.

oliviertassinari avatar oliviertassinari commented on May 19, 2024

Yes, we already have this done in the Q4 zip waiting to be deployed.

cc @DavidCnoops 🙏

from mui-design-kits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.