Comments (13)
I agree :) Although, I don't have much experience with Sass. Would love some help on this one.
from material-ui.
I'd say having a css distributable would be the way around most of these issues.
from material-ui.
+1 to a distributable .css file. The internals of the package shouldn't really matter unless someone was looking to fork it and edit the guts of the LESS for their own project, in which case, I don't think its on the maintainer to provide that (which would imply you would need to supply stylus and pure css as well).
from material-ui.
+1 to both a .scss file and a compiled .css version. Sass is widely used and having options could solve some of the issues
from material-ui.
You can check out #56 for discussions about creating a .css distributable.
from material-ui.
I'm willing to contribute towards a SASS port, since there seems to be some interest. I think that would be crucial in the long run for encouraging adoption with some of the major frameworks such as Foundation and Bootstrap. Will fork it and dig into the code over the weekend to see what all would be involved... Really love what you guys have done here by the way.
from material-ui.
@danielsmcclintock if you need help for that, I can help. I can't stay sassless.
from material-ui.
I've started a small repo: material-ui-sass where I would convert from less to sass the CSS framework. Never made something like this before, so I don't know how hard will it be and how we could keep the things in sync. Luckily it looks like the less files are simple and solid enough...
@DUBERT @danielsmcclintock and others, who wants to join? :-)
@hai-cea please tell me if you don't agree with this idea, maybe we should do this in another way...
from material-ui.
I'd love to help too, @gpbl :)
from material-ui.
@gpbl Thanks for taking this on! 👍
from material-ui.
@gpbl thx for taking the initiative. I was out of pocket last week, so wasn't able to start earlier as I wished. I forked this repo earlier, but it makes no difference which one serves as the main trunk...as long as we kick ass and take names. :) I'm fine with forking your repo and submitting pull requests to you as long as you're comfortable managing the pull requests/issues, and keeping it on track with this repo.
Open to any feedback from @hai-cea also.
from material-ui.
I'm finished with the conversion, we can now use sass as well! Please check material-ui-sass. Suggestions and improvements are welcome.
@hai-cea thank you for allowing us doing this. I'm sure people using Sass will appreciate. Would you like add a reference to material-ui-sass in the README.md?
from material-ui.
@gpbl yes that's good idea - do you want to submit a PR?
from material-ui.
Related Issues (20)
- [core] Adopt eslint-plugin-react-compiler
- [material-ui] Textfield add autoSelect prop HOT 8
- When trying to link an application using MUI v5, application gets "TypeError: Cannot read properties of null (reading 'useContext')"
- can't set drawer root element HOT 1
- [material-ui][Rating] Screen reader announces incorrect value for maximum amount of stars
- [core] Fix eslint-plugin-react-compiler issues HOT 8
- Maps autocomplete example documentation incomplete
- [examples] Migrate Next.js config.next.js to config.next.mjs HOT 1
- dashed borderStyle does not work for Divider with text HOT 1
- [Checkbox] Checkbox color prop don't honor passed in color when theme has default props for MuiSvgIcon HOT 3
- [joy-ui] Cannot set `color` or `bgcolor` of `Box` when used in Next.js HOT 1
- [Breadcrumbs] Allow overriding `onClick` button base of ellipsis icon
- [Alert] TS error when using slotProps with customised component HOT 4
- [react 19][tooltip] Accessing element.ref was removed in React 19
- [material-ui] Prototype pollution security vulnerabililty in @mui/utils HOT 8
- [material-ui] Sign-in template improvements
- [material-ui] Dashboard template improvements
- [material-ui][Masonry] layout forms a single column when the first item is hidden HOT 4
- MUI Joy UI Autocomplete crashing my app HOT 2
- [Snackbar][docs] Stop recommending the usage of notistack, the library is seemingly no longer (properly) maintained
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.