Giter Club home page Giter Club logo

Comments (1)

brijeshb42 avatar brijeshb42 commented on April 30, 2024

Here's a small change I made in your themeProvider

import { ThemeProvider as MuiThemeProvider } from '@mui/material/styles';
import {createContext, PropsWithChildren, useCallback, useEffect, useMemo, useState} from "react";
import theme from '../src/theme';

type IThemeSwitch = {
  setTheme: (name: string) => void;
}

export const SwitchContext = createContext<IThemeSwitch>({
  setTheme: () => undefined,
});

export const ThemeProvider = ({ children}: PropsWithChildren) => {
  const [themeName, setTheme] = useState('');

  const setThemeWithLs = useCallback((newTheme: string) => {
    setTheme(newTheme);
    window.localStorage.setItem('themeName', newTheme);
  }, []);
  const switchValue = useMemo(() => ({ setTheme: setThemeWithLs }), [setThemeWithLs])

  useEffect(() => {
    const lsTheme = window.localStorage.getItem('themeName');
    if (lsTheme) {
      setTheme(lsTheme);
    }
  }, [])

  const themeValue = useMemo(() => {
    return themeName === 'dark' ? theme.dark : theme.light;
  }, [themeName])

  return (
    <SwitchContext.Provider value={switchValue}>
      <MuiThemeProvider theme={themeValue}>
        {children}
      </MuiThemeProvider>
    </SwitchContext.Provider>
  )
}

There was a hydration mismatch because of how the use-local-storage library initialized that state.
Not that the fix might have a flash of theme change (BE sending light and then client setting it to dark). So you might need to use cookies for saving theme.

Feel free to re-open if you face any other issue.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.