Giter Club home page Giter Club logo

Comments (4)

muesli avatar muesli commented on June 8, 2024 1

Hey @jcf!

Thank you for your contribution and your kind words! This looks great, I'll just have to try it out on my own machine.

One thing I noticed at a first glance is the changed product ID. I assume you got a newer revision of the Streamdeck with a different ID, which I wasn't aware of. We'll probably have to support both 006c and 006d here. This also means we should update the README and/or integrate the udev rules in the repo for convenience.

We should also think about printing out the required systemd commands upon successful installation of the AUR package. Last but not least, we need to unify the -git, -bin and regular AUR package a bit.

Thanks again!

from deckmaster.

jcf avatar jcf commented on June 8, 2024

One thing I noticed at a first glance is the changed product ID. I assume you got a newer revision of the Streamdeck with a different ID, which I wasn't aware of. We'll probably have to support both 006c and 006d here. This also means we should update the README and/or integrate the udev rules in the repo for convenience.

I figured the same, but wasn't sure which product codes were which. I know the 15 button Stream Deck I have corresponds to the /dev/streamdeck entry in the udev rules.

We should also think about printing out the required systemd commands upon successful installation

This isn't something I've adding to a package before, but I see mention of .install files where printf can be used to log important information:

All important messages should be echoed during install using an .install file. For example, if a package needs extra setup to work, directions should be included.

we need to unify the -git, -bin and regular AUR package

This would be awesome! I'm not sure how best to do this. I thought maybe a contrib directory in this repo that can generate both AUR packages would be a way to share common configuration, but perhaps there's a more elegant way to do this.

from deckmaster.

muesli avatar muesli commented on June 8, 2024

I figured the same, but wasn't sure which product codes were which. I know the 15 button Stream Deck I have corresponds to the /dev/streamdeck entry in the udev rules.

The 006c rule also matches the (first revision?) 15-button (mid-size) Stream Deck.

This isn't something I've adding to a package before, but I see mention of .install files where printf can be used to log important information:

Great, that's what I was thinking of!

This would be awesome! I'm not sure how best to do this. I thought maybe a contrib directory in this repo that can generate both AUR packages would be a way to share common configuration, but perhaps there's a more elegant way to do this.

Yeah, I think that's the easiest way to achieve this and might also help other packagers. Maybe contrib isn't the best name though, as that typically describes externally maintained stuff. I've used admin in other projects before, but that doesn't seem quite fitting either. I'm open for suggestions! 😄

Want to do the honors and come up with an initial PR for this? ❤️

from deckmaster.

vancluever avatar vancluever commented on June 8, 2024

@muesli looks like this stalled a while ago (quite a while, hah 😉 ) but I still think it needs attention to make sure new users don't need so much manual installation. I'm happy to send off the PRs necessary to make these fixes as I've made some additions to the deckmaster-bin package locally to help with this. Let me know!

from deckmaster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.