New tag does not appear in the tag list about moememosandroid HOT 5 CLOSED

In web/src/components/MemoEditor.tsx:handleSaveBtnClick, Memos Web getMatchedNodes from content.

    // Upsert tag with the content.
    const matchedNodes = getMatchedNodes(content);
    const tagNameList = uniq(matchedNodes.filter((node) => node.parserName === "tag").map((node) => node.matchedContent.slice(1)));
    for (const tagName of tagNameList) {
      await tagStore.upsertTag(tagName);
    }

getMatchedNodes match nodes by some rules defined in web/src/labs/marked/parser/, and what we interested in is web/src/labs/marked/parser/Tag.tsx. It extracts tags by regular expression /#([^\s#]+)/.

I have added some code to update tags, but I don't find a good expression which can find all tags. Thanks if somebody could help me!

from moememosandroid.

When I test a case like this:

#111 #222 #测试 #cs 测试

It can not identify chinese tags and English tags.

But if I do not match digits, it will work as expected:

from moememosandroid.

Thanks for the discussion!

One thing we need to take into account is # mark in certain Markdown elements (code block, links, images, etc) should be avoided. I guess it could be done with intellij-markdown.

Or I wonder whether it's possible extend intellij-markdown to support tags in a native way. (That will let memo card render tags too)

from moememosandroid.

Thanks for the discussion!

One thing we need to take into account is # mark in certain Markdown elements (code block, links, images, etc) should be avoided. I guess it could be done with intellij-markdown.

Or I wonder whether it's possible extend intellij-markdown to support tags in a native way. (That will let memo card render tags too)

Yes, you are right, I forget # is widely used in different elements. I have some questions about where to parse markdown elements in MemoInputPage.kt:submit. I find Markdown is used in Memocard.kt, but we may analyze markdown elements in submit method?

For I have accomplish updateTag API (it is easy) and not sure how to accomplish parser, can I take a pr for only updateTag API or accomplish all features? I'm not a Android developer, and I'm a new hand in open source contribution. Thank you!

from moememosandroid.

Thanks for the discussion!
One thing we need to take into account is # mark in certain Markdown elements (code block, links, images, etc) should be avoided. I guess it could be done with intellij-markdown.
Or I wonder whether it's possible extend intellij-markdown to support tags in a native way. (That will let memo card render tags too)

Yes, you are right, I forget # is widely used in different elements. I have some questions about where to parse markdown elements in MemoInputPage.kt:submit. I find Markdown is used in Memocard.kt, but we may analyze markdown elements in submit method?

For I have accomplish updateTag API (it is easy) and not sure how to accomplish parser, can I take a pr for only updateTag API or accomplish all features? I'm not a Android developer, and I'm a new hand in open source contribution. Thank you!

Thanks! It's super welcome for any contribution and it's not required to be feature completed 😆

For reference, the parser used by MemosCard is https://github.com/mudkipme/MoeMemosAndroid/blob/main/app/src/main/java/me/mudkip/moememos/ui/component/Markdown.kt#L41

from moememosandroid.