All slider in jalv.gtk generic ui ignored. about helm HOT 5 CLOSED

Seems like the plugin is completely ignoring parameter changes
https://github.com/mtytel/helm/blob/master/src/plugin/helm_plugin.cpp#L178

EDIT: that's incorrect. that function is a message callback, not the function that is called when a parameter changes.

from helm.

Ok, going through the code...

helm uses the new juce api to handle plugins:
https://github.com/mtytel/helm/blob/master/src/plugin/helm_plugin.cpp#L38

with that the plugin class doesn't need to handle parameter changes directly.
in helm's case it uses this class/code for parameters:
https://github.com/mtytel/helm/blob/master/src/plugin/value_bridge.h#L24

when a parameter is changed by the host the 'setValue' function is called:
https://github.com/mtytel/helm/blob/master/src/plugin/value_bridge.h#L42

as we see in this line, the listener is registered:
https://github.com/mtytel/helm/blob/master/src/plugin/helm_plugin.cpp#L36

so the parameter value does get changed and parameterChanged is called.
(ie this https://github.com/mtytel/helm/blob/master/src/plugin/helm_plugin.cpp#L178)

so perhaps 'setValue' is never called?
tbh this is a first time I see an opensource juce plugin that uses the new api.

btw, parameterChanged is calling gui functions and allocating string data, which is really awful for realtime.
Automating a value while the UI is open will result in xruns.

from helm.

Hmmmm.... Going to have a look at this over the weekend. Maybe I should refactor this a bit so it doesn't use strings.

from helm.

Well I finally got around to this bug, but it's actually working for me.
I just open Helm with generic UI and set the amp_release parameter really high. Not sure if I'm missing something here..

Also, the listener callback is just to alert the GUI that a value was changed from the host. The actually value used in synthesis is set here: https://github.com/mtytel/helm/blob/master/src/plugin/value_bridge.h#L47
Don't know why I have a return statement there though..

from helm.

Going to mark this done because it worked for me?

from helm.