Comments (5)
Hello
So the /card/ prefix on mtgimage does not directly map to the 'imageName' field.
The 'imageName' field is only used for the '/set/XXX/imageName.jpg' prefix
The /card/ prefix only has the very latest printing of a card (as there is only 1 card per card name) and thus the extra art cards (which is what the number suffixes are used for) don't make sense in this case.
Does this explanation make sense?
I should probably update the MTGJSON docs to clarify this.
from mtgjson3.
Got it - I thought it might be something along these lines.
This makes perfect sense in context of AllSets.json
, where the cards are inherently organized by set. That being said, wouldn't it make more sense to modify the field in AllCards.json
to reflect the most recent printing of the card?
[AllCards.json] is lighter weight and is meant to provide a quick and easy way to get basic card data.
Given that "basic card data" does not seem to currently contain sets where a card was included, it is currently non-trivial to fetch the card image from the information provided in AllCards.json
. As far as I can tell, for any given card, it's not possible to determine which set I'd need to look under with the /set/[set name]/[image name].jpg
prefix.
from mtgjson3.
Ahh yes, excellent point about AllCards.json. I will be updating the field in this file so it works with /card/ and I'll update the docs to mention which prefix to use depending on file.
from mtgjson3.
Marvelous! 👍
from mtgjson3.
Just updated the site, fixed! Every imageName field for all cards in AllCards.json correctly works with the /card/ prefix now. Also updated the docs. Thanks :)
from mtgjson3.
Related Issues (20)
- layout and names incorrect for Zndrsplt, Eye of Wisdom and Okaun, Eye of Chaos HOT 2
- Arena promos (pARL) release dates are wrong HOT 1
- Host is supertype, not type HOT 1
- Un-card legalities are inconsistent HOT 1
- Inconsistent use of setcode "ALL" HOT 2
- Same card, different mana cost HOT 2
- Color indicator is missing HOT 1
- Cards missing from pHHO and ARC HOT 2
- Fate Reforged Clash Pack Typo HOT 1
- B.F.M. (Big Furry Monster, Right Side) has duplicate entry in AllSets.json HOT 1
- Overgrown Tomb and Temple Garden missing cipt HOT 4
- Zndrsplt & Okaun layout set to "flip" HOT 1
- Please use ASCII subtract for loyalty costs HOT 2
- Some Battlebond partner cards have layout 'Flip' HOT 2
- Create version.json file for MTGJSONv4 HOT 1
- Teferi, Hero of Dominaria out of date HOT 1
- "aftermath" card layout type is gone, now "split" type HOT 5
- GRN guild kits HOT 1
- Righteous Blow's Printings Missing GRN HOT 4
- Bloated file size HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mtgjson3.