Error when calling findFirst even though nothing has changed about data HOT 9 CLOSED

Hi @camchenry thanks for raising the issue :).

I think that making the property enumerable should solve the issue. I have already done it in the same PR as for the other issue because I need it for deleting internal properties.

from data.

@kettanaito Sure! I'll try to get around to it today and put up a PR.

from data.

@kettanaito i think with the tests written and the manual testing I've done, I think the original issue should be fixed 🤞

from data.

Thanks for raising this, @camchenry. You've been immensely helpful in uncovering these behaviors. That's indeed an issue and we should fix it in the upcoming release.

@marcosvega91, I'll take a look at the internal properties removal pull request once more (#67), would love to get it merged. It's a superb piece of work already, so huge thanks! I have one concern, but we'll figure it out.

from data.

The issue itself is addressed in #67, but we need to add a test for it. @camchenry, please, would you be interested in contributing the relevant test? We can support you throughout the process and have this not only fixed but bullet-proofed against any future regressions?

from data.

Released in 0.3.0. Please give it a try, your feedback is highly valuable!

from data.

@marcosvega91 Sounds great! I will look forward to when that releases then.

from data.

With the test added, is there anything left to address to mark this as done, @camchenry?

from data.

@kettanaito Any chance this will make it into a new release sometime soon? This was somewhat of a blocker in my project, but I'd like to give it another go and see if I can uncover any more issues.

from data.