Giter Club home page Giter Club logo

Comments (2)

msinto93 avatar msinto93 commented on July 21, 2024

I don't think its really necessary to have a lock between the agents themselves. Of course, if you want to be 100% 'thread-safe' then yes you could do this, but any other implementations I've seen of multi-threaded data gathering do not bother with this. The way I see it is that the worst that could happen is that on the rare occasions two or more agents try to add their samples at the same time, one sample may be overwritten. This isn't a significant issue given that we aren't adding to the buffer every step, only at the end of an episode, so the chances of trying to add at the exact same time as another agent are fairly low.

from d4pg.

yuyuguru avatar yuyuguru commented on July 21, 2024

I don't think its really necessary to have a lock between the agents themselves. Of course, if you want to be 100% 'thread-safe' then yes you could do this, but any other implementations I've seen of multi-threaded data gathering do not bother with this. The way I see it is that the worst that could happen is that on the rare occasions two or more agents try to add their samples at the same time, one sample may be overwritten. This isn't a significant issue given that we aren't adding to the buffer every step, only at the end of an episode, so the chances of trying to add at the exact same time as another agent are fairly low.

thanks!

from d4pg.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.