Giter Club home page Giter Club logo

Comments (10)

msikma avatar msikma commented on June 28, 2024 4

Yes, unfortunately I don't see a better way to do it at the moment. Although I understand your misgivings about it.

It's a requirement that we don't break the existing use of the project, and people are massively linking to the files directly on the master branch, so we can't really touch it. In fact, that's why there's tons of legacy files under /icons/pokemon as well—that's where the box sprites were originally located before being moved to separate directories in the root. Breaking this structure would cause a lot of trouble for a lot of people, so I want to avoid that if possible.

It's worth considering that a lot of people using these sprites are not application developers and don't follow the standard way of using a repo, so that's what led to the current situation.

But I think it's OK. master is a legacy branch name to begin with. We'll set the main branch to main so that that's what you'll see when you visit the project on Github or clone the repo. This will keep all existing links intact. The only thing is someone may be a bit confused when they look at the list of branches, but I think most developers will understand what happened at a glance. The master branch will also get a proper notification in the readme that it only exists for legacy purposes.

from pokesprite.

sora10pls avatar sora10pls commented on June 28, 2024 3

Here's a proper dump of said sprites, not in a montage.

from pokesprite.

shankarsivarajan avatar shankarsivarajan commented on June 28, 2024 2

Surely no one is relying on the master branch of someone else's repo being stable? If there are no tagged release branches, the obvious thing to do is to fork a copy. Efforts to maintain backwards-compatibility here is solving a problem that doesn't really exist: any project that links directly to the master branch is clearly signaling that they're actively maintaining their application, and can easily adapt to any changes upstream by changing links as needed.

And the master vs. main thing was a passing American culture-war fad from a few years ago, mostly only expressed by a few corporations, primarily Google, Facebook, and Microsoft, which owns Github, and so changed the default. Again, this is trying to solve a problem one has imagined into existence.

The natural thing to do is just release a version v1.0.0 or legacy or whatever, so anyone who wants to keep their current version can use that, and then update the current branch, called master, main, updated, new, v2.0.0, or whatever else one wishes.

from pokesprite.

Or1onCL avatar Or1onCL commented on June 28, 2024

Hi, a few hours ago @CentroLeaks posted the sv sprites for most of the pokemons (normal, mega, iconic gender differences).
Attached link.
CentroLeaks

from pokesprite.

shankarsivarajan avatar shankarsivarajan commented on June 28, 2024

Suggestion: better handling of variants. If I wanted to find the sprite for something like [pokémon name]-female-[region]-[form]-mega-shiny, it's very hard with the current flat structure of the sprite directory. More hierarchy would help, as would a database listing which variants exist for each pokémon.

from pokesprite.

shankarsivarajan avatar shankarsivarajan commented on June 28, 2024

Please don't use master vs main as your version control. If you're making breaking changes, use semantic versioning, and call the new one pokesprite-v2.0.0 (or something like that). Alternatively, issue a deprecation warning and actually break it, calling the new version master and renaming the old version legacy.

from pokesprite.

koenigderluegner avatar koenigderluegner commented on June 28, 2024

Please don't use master vs main as your version control. If you're making breaking changes, use semantic versioning, and call the new one pokesprite-v2.0.0 (or something like that). Alternatively, issue a deprecation warning and actually break it, calling the new version master and renaming the old version legacy.

There are at least two reasons behind the change to main: a deprecation warning wont help as many, many resources link directly to the raw urls of this repos files. Changing the structure of the master branch will break all those resources as they cant receive a deprecation warning (example: spreadsheets in many pokemon communities)

Second: the term master itself has some historical meanings why its common to be be 'main' now. 'main' is the default in new projects and this one will just go with the rest.

AFAIK a new handling of files and versioning will come anyway - just including the name change

from pokesprite.

koenigderluegner avatar koenigderluegner commented on June 28, 2024

As I said, a lots of communities do rely on master with their spreadsheets for example, most of them are not tech-savvy enough to figure out whats happening when all their sprites disappear.

Also there's always the possibility for you to make a fork and just do the versioning yourself, if you're not satisfied with how it goes.

from pokesprite.

shankarsivarajan avatar shankarsivarajan commented on June 28, 2024

Well, he did ask for suggestions, and "don't implement the abominable version control system you're planning" is mine.

from pokesprite.

koenigderluegner avatar koenigderluegner commented on June 28, 2024

And that's absolutely fine. I just tried to tell you why the decisions were made.
There already is versioning, current one being 2.7.0.
And as I said before

AFAIK a new handling of files and versioning will come anyway - just including the name change

There most likely will be versioning going further - just trying to not mess up hundreds, maybe thousands of other resources for problems one has imagined into existence ;).

from pokesprite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.