Cannot destructure property `number` of 'undefined' or 'null' about add-pr-comment HOT 5 CLOSED

I just re-published v1 to the marketplace with the feature you introduced me to @kceb. My implementation was a little more in the official GitHub Action style, but your PR was a huge help.

You can now use this action on triggers other than on: pull_request. This means you can update a PR issue post-merge, to update the status on some sort of deployment, which I believe was your use case @shanedroid.

Thanks for helping me make this action better. Please feel free to let me know how it's going.

from add-pr-comment.

It looks like you're running this on a push to master, which does not contain an issue number. You can only use it on these triggers:

on:
  pull_request:

I can probably handle this case better, and output something into your logs rather than failing hard. Will put a fix out shortly.

from add-pr-comment.

@mshick I'd like to use this action to post a comment on the PR with the iOS/Android builds after it is merged to master. Seems like it's not possible because it only runs on pull request triggers. Is there a way to add that functionality or does github not make it possible?

I made a github action to get the URL of the PR here: https://github.com/kceb/pull-request-url-action
and it seems to be working on merges.

Edit: Created a PR with changes I made in my fork: https://github.com/mshick/add-pr-comment/pull/4/files

from add-pr-comment.

@shanedroid lmk if my fork works out for you: https://github.com/kceb/add-pr-comment

from add-pr-comment.

you can filter jobs do only run on pull requests with the if option:

  jobName:
    if: contains(github.ref, 'pull')
    steps:
      ...

from add-pr-comment.