Giter Club home page Giter Club logo

Comments (5)

casperisfine avatar casperisfine commented on June 26, 2024 2

@tagomoris yes, I just tried my branch and it fixes it:

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  gem "minitest"
  gem "stripe"
  gem "msgpack", github: "https://github.com/msgpack/msgpack-ruby/pull/276"
end

require "msgpack"
require "stripe"
require "minitest/autorun"

MessagePack::DefaultFactory.register_type(
  0x02, Stripe::Price,
  packer: lambda { |price, packer|
    packer.write_hash({ foo: :bar })
  },
  unpacker: ->(unpacker) { unpacker.read },
  recursive: true
)

class BugTest < Minitest::Test
  def test_dumping_and_loading
    price1 = Stripe::Price.construct_from({"id" => "1", "object" => "price"})
    price2 = Stripe::Price.construct_from({"id" => "2", "object" => "price"})

    assert_equal({"foo" => "bar"}, MessagePack.load(MessagePack.dump(price1)))
    assert_equal({"foo" => "bar"}, MessagePack.load(MessagePack.dump(price2)))
    assert_equal([{"foo" => "bar"}, {"foo" => "bar"}], MessagePack.load([price1, price2].to_msgpack))
  end
end

from msgpack-ruby.

tagomoris avatar tagomoris commented on June 26, 2024

@casperisfine does this relates to #276?
(Sorry for the rate review on it)

from msgpack-ruby.

tagomoris avatar tagomoris commented on June 26, 2024

I've released v1.5.2 with the fix #276.
I can't check the script works well with it for now (due to a DNS problem), though.

from msgpack-ruby.

tagomoris avatar tagomoris commented on June 26, 2024

It runs well with msgpack 1.5.2 on my laptop. Thank you for reporting @npezza93 and fixing it @casperisfine !

from msgpack-ruby.

npezza93 avatar npezza93 commented on June 26, 2024

Swwet, thanks @tagomoris! Looks like everything is working in 1.5.2

from msgpack-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.