Giter Club home page Giter Club logo

Comments (7)

MrWolfZ avatar MrWolfZ commented on July 27, 2024

Hmm, not sure there needs to be a dedicated function for this in the library. You could simply do this: formState.controls.filter(c => c.isDirty).map(c => c.value) if you want to get an array of only the values that are dirty.

from ngrx-forms.

patricknazar avatar patricknazar commented on July 27, 2024

Thanks, but I get formState.controls.filter is not a function also, what about nested controls? I would need the whole tree of dirty values.

from ngrx-forms.

patricknazar avatar patricknazar commented on July 27, 2024

I've come up with this recursive function to do it. It would be nice to be able to force certain properties on it though, such as id or addresses[x].id etc. Another reason why I thought making a more powerful/generic function would be good.

filterForDirty(controls) {
    const dirtyTree = {};

    for (const key in controls) {
      if (controls.hasOwnProperty(key)) {
        const value = controls[key];
        if (value.isDirty) {
          dirtyTree[key] = (value.controls ? filterForDirty(value.controls) : value.value);
        }
      }
    }

    return dirtyTree;
  }

from ngrx-forms.

MrWolfZ avatar MrWolfZ commented on July 27, 2024

from ngrx-forms.

MrWolfZ avatar MrWolfZ commented on July 27, 2024

Hmm, so I tried out writing map, filter, and reduce functions and it turns out while it is somewhat possible to write them they don't really make much sense in the context of form states after all.

The only thing that kind of works out is filter but I feel that the use cases this would be useful for are very rare.

Here is a version of getFilteredValue that is a bit more generic and properly typed compared to your version if you want to use it (haven't really tested it, so it might contains bugs).

import {
  AbstractControlState,
  FormArrayState,
  FormControlState,
  FormControlValueTypes,
  FormGroupState,
  isGroupState,
  isArrayState,
  KeyValue,
} from 'ngrx-forms';

export function getFilteredValue<T extends FormControlValueTypes>(
  state: FormControlState<T>,
  filterFn: (state: AbstractControlState<T>) => boolean,
): T | undefined;

export function getFilteredValue<T>(
  state: FormArrayState<T>,
  filterFn: (state: AbstractControlState<any>) => boolean,
): T[] | undefined;

export function getFilteredValue<T extends KeyValue>(
  state: FormGroupState<T>,
  filterFn: (state: AbstractControlState<any>) => boolean,
): Partial<T> | undefined;

export function getFilteredValue<T>(
  state: AbstractControlState<T>,
  filterFn: (state: AbstractControlState<any>) => boolean,
): T | undefined;

export function getFilteredValue<T>(
  state: AbstractControlState<T>,
  filterFn: (state: AbstractControlState<T>) => boolean,
): T | Partial<T> | T[] | undefined {
  if (!filterFn(state)) {
    return undefined;
  }

  if (isGroupState(state)) {
    const groupState = state;
    return Object.keys(groupState.controls).reduce((c, key) => {
      const childState = groupState.controls[key];
      const filteredValue = getFilteredValue(childState, filterFn);

      if (filteredValue !== undefined) {
        Object.assign(c, { [key]: filteredValue });
      }

      return c;
    }, {} as Partial<T>);
  }

  if (isArrayState(state)) {
    return state.controls.map(childState => getFilteredValue(childState, filterFn)!).filter(s => !!s);
  }

  return state.value;
}

from ngrx-forms.

MrWolfZ avatar MrWolfZ commented on July 27, 2024

Closing this. If you have any more questions or ideas please feel free to open a new issue.

from ngrx-forms.

patricknazar avatar patricknazar commented on July 27, 2024

Sorry for the late reply, thanks for your efforts.

from ngrx-forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.