Giter Club home page Giter Club logo

Comments (4)

MrOlm avatar MrOlm commented on August 20, 2024

Hi Johannes,

That's really weird...

It seems like this would happen if 1) all your genomes got filtered out, or 2) the *.fna isn't hitting any genomes.

In the data_tables/ folder, there should be a file called Bdb.csv. Does that have any genomes in it?

Additionally, with the above step (the filtering step), does it say something like X genomes passed quality filtering?

-Matt

from drep.

fungs avatar fungs commented on August 20, 2024

You are right, it seems to be the filtering, though this shouldn't result in an error like this IMO.

***************************************************
    ..:: dRep dereplicate Step 1. Filter ::..
***************************************************
    
Will filter the genome list
Calculating genome info of genomes
50.00% of genomes passed length filtering
Running prodigal
Running checkM
0.00% of genomes passed checkM filtering

Bdb.csv is empty, accordingly. I suppose it's easy to fix and stop after step 1, if now genome passes the filtering. Similarly, I would try to catch an empty list of files in the input to improve the usability.

BTW: What happens, if file names or sequences IDs contain commas, is that escaped in the CSV files? Wouldn't it be better to report using tab-separated TSV files?

Best,
Johannes

from drep.

MrOlm avatar MrOlm commented on August 20, 2024

Hi Johannes,

Thanks for the suggestion- will add to my internal to-do list.

As for the commas, they are current not escaped. You are right that maybe I should have done TSV files from the get-go, but as it would be a pain to change now and because commas in filenames are very rare, I will probably not change it unless it becomes a bigger issue.

Best,
-Matt

from drep.

fungs avatar fungs commented on August 20, 2024

Hi Matt,

what about leaving bug reports open until they have been addressed in a commit?

PS: I do have commas in many files.

from drep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.